[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 05/14] block/nvme: Improve error message when IO queue creatio
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v4 05/14] block/nvme: Improve error message when IO queue creation failed |
Date: |
Wed, 12 Aug 2020 20:50:05 +0200 |
Do not use the same error message for different failures.
Display a different error whether it is the CQ or the SQ.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
block/nvme.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/nvme.c b/block/nvme.c
index 003809fbd8..53448b7d23 100644
--- a/block/nvme.c
+++ b/block/nvme.c
@@ -648,7 +648,7 @@ static bool nvme_add_io_queue(BlockDriverState *bs, Error
**errp)
.cdw11 = cpu_to_le32(0x3),
};
if (nvme_cmd_sync(bs, s->queues[INDEX_ADMIN], &cmd)) {
- error_setg(errp, "Failed to create io queue [%d]", n);
+ error_setg(errp, "Failed to create CQ io queue [%d]", n);
nvme_free_queue_pair(q);
return false;
}
@@ -659,7 +659,7 @@ static bool nvme_add_io_queue(BlockDriverState *bs, Error
**errp)
.cdw11 = cpu_to_le32(0x1 | (n << 16)),
};
if (nvme_cmd_sync(bs, s->queues[INDEX_ADMIN], &cmd)) {
- error_setg(errp, "Failed to create io queue [%d]", n);
+ error_setg(errp, "Failed to create SQ io queue [%d]", n);
nvme_free_queue_pair(q);
return false;
}
--
2.21.3
- [PATCH v4 00/14] block/nvme: Various cleanups required to use multiple queues, Philippe Mathieu-Daudé, 2020/08/12
- [PATCH v4 01/14] block/nvme: Replace magic value by SCALE_MS definition, Philippe Mathieu-Daudé, 2020/08/12
- [PATCH v4 02/14] block/nvme: Avoid further processing if trace event not enabled, Philippe Mathieu-Daudé, 2020/08/12
- [PATCH v4 03/14] block/nvme: Let nvme_create_queue_pair() fail gracefully, Philippe Mathieu-Daudé, 2020/08/12
- [PATCH v4 04/14] block/nvme: Define INDEX macros to ease code review, Philippe Mathieu-Daudé, 2020/08/12
- [PATCH v4 05/14] block/nvme: Improve error message when IO queue creation failed,
Philippe Mathieu-Daudé <=
- [PATCH v4 06/14] block/nvme: Use common error path in nvme_add_io_queue(), Philippe Mathieu-Daudé, 2020/08/12
- [PATCH v4 07/14] block/nvme: Rename local variable, Philippe Mathieu-Daudé, 2020/08/12
- [PATCH v4 08/14] block/nvme: Use union of NvmeIdCtrl / NvmeIdNs structures, Philippe Mathieu-Daudé, 2020/08/12
- [PATCH v4 09/14] block/nvme: Replace qemu_try_blockalign0 by qemu_try_blockalign/memset, Philippe Mathieu-Daudé, 2020/08/12
- [PATCH v4 10/14] block/nvme: Replace qemu_try_blockalign(bs) by qemu_try_memalign(pg_sz), Philippe Mathieu-Daudé, 2020/08/12
- [PATCH v4 11/14] block/nvme: Simplify nvme_init_queue() arguments, Philippe Mathieu-Daudé, 2020/08/12
- [PATCH v4 12/14] block/nvme: Replace BDRV_POLL_WHILE by AIO_WAIT_WHILE, Philippe Mathieu-Daudé, 2020/08/12
- [PATCH v4 13/14] block/nvme: Simplify nvme_create_queue_pair() arguments, Philippe Mathieu-Daudé, 2020/08/12
- [PATCH v4 14/14] block/nvme: Extract nvme_poll_queue(), Philippe Mathieu-Daudé, 2020/08/12