[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.2 3/3] hw/misc/unimp: Display the offset with width of
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH-for-5.2 3/3] hw/misc/unimp: Display the offset with width of the region size |
|
Date: |
Wed, 12 Aug 2020 20:52:50 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 8/12/20 7:34 PM, Richard Henderson wrote:
> On 8/7/20 7:37 AM, Philippe Mathieu-Daudé wrote:
>> + s->offset_fmt_width = ROUND_UP(64 - clz64(s->size - 1), 4) >> 2;
>
> Better with DIV_ROUND_UP, I think. Otherwise,
Thanks for the tip! (and for reviewing the other series) :)
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
>
> r~
>