Re: [RFC 0/9] Support disable/enable CPU features for AArch64

[no-reply]

Patchew URL: 
20200813102657.2588720-1-liangpeng10@huawei.com/">https://patchew.org/QEMU/20200813102657.2588720-1-liangpeng10@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200813102657.2588720-1-liangpeng10@huawei.com
Subject: [RFC 0/9] Support disable/enable CPU features for AArch64

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
155e490 target/arm: Add more CPU features
5564d59 target/arm: Update ID fields
2f12ecd target/arm: Add CPU features to query-cpu-model-expansion
0911682 target/arm: introduce KVM_CAP_ARM_CPU_FEATURE
9dddca9 target/arm: introduce CPU feature dependency mechanism
89874bb target/arm: Allow ID registers to synchronize to KVM
8286a4a target/arm: register CPU features for property
7101c88 target/arm: parse cpu feature related options
56111cc target/arm: convert isar regs to array

=== OUTPUT BEGIN ===
1/9 Checking commit 56111cc30af0 (target/arm: convert isar regs to array)
2/9 Checking commit 7101c885db04 (target/arm: parse cpu feature related options)
ERROR: consider using qemu_strtoupr in preference to strtoupr
#55: FILE: target/arm/cpu64.c:799:
+static char *strtoupr(char *str)

ERROR: consider using qemu_strtoupr in preference to strtoupr
#121: FILE: target/arm/cpu64.c:865:
+        tmp = strtoupr(tmp);

ERROR: consider using qemu_strtoupr in preference to strtoupr
#127: FILE: target/arm/cpu64.c:871:
+        const char *name = strtoupr(l->data); /* convert to upper string */

ERROR: consider using qemu_strtoupr in preference to strtoupr
#132: FILE: target/arm/cpu64.c:876:
+        const char *name = strtoupr(l->data);

total: 4 errors, 0 warnings, 119 lines checked

Patch 2/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/9 Checking commit 8286a4a789ed (target/arm: register CPU features for 
property)
4/9 Checking commit 89874bbdfd8e (target/arm: Allow ID registers to synchronize 
to KVM)
5/9 Checking commit 9dddca93c5b1 (target/arm: introduce CPU feature dependency 
mechanism)
6/9 Checking commit 091168210d47 (target/arm: introduce KVM_CAP_ARM_CPU_FEATURE)
7/9 Checking commit 2f12ecd63d30 (target/arm: Add CPU features to 
query-cpu-model-expansion)
ERROR: consider using qemu_strtolower in preference to strtolower
#32: FILE: target/arm/cpu.c:1520:
+static char *strtolower(char *src)

ERROR: consider using qemu_strtolower in preference to strtolower
#64: FILE: target/arm/cpu.c:1552:
+            tmp = strtolower(g_strdup(name));

total: 2 errors, 0 warnings, 67 lines checked

Patch 7/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

8/9 Checking commit 5564d59a9ee0 (target/arm: Update ID fields)
9/9 Checking commit 155e490920e3 (target/arm: Add more CPU features)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200813102657.2588720-1-liangpeng10@huawei.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200813102657.2588720-1-liangpeng10@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com