Re: [PATCH v13 00/11] iotests: Dump QCOW2 dirty bitmaps metadata

[Andrey Shinkevich]

Dear Eric!

Vladimir has compeated reviewing this series. I have not received any 
other responses to it so far.

So, is it good for pull request now? Would you please consider taking 
this series as you did it with the Vladimir's related one?

Kindly,
Andrey


On 06.08.2020 22:35, Andrey Shinkevich wrote:
> Add dirty bitmap information to QCOW2 metadata dump in the qcow2_format.py.
>
> v13:
>    01: Bitmaps are added without launching VM (suggested by Eric).
>        The code amendments suggested by Vladimir.
>    07: Bitmap table entry size zeroed up for all types but serialized.
>    09: The extra dict variables removed. to_dict() renamed to to_json().
>        The to_json() added to the class Qcow2BitmapTable. (By Vladimir).
>
>
> Andrey Shinkevich (11):
>    iotests: add test for QCOW2 header dump
>    qcow2_format.py: make printable data an extension class member
>    qcow2_format.py: change Qcow2BitmapExt initialization method
>    qcow2_format.py: dump bitmap flags in human readable way.
>    qcow2_format.py: Dump bitmap directory information
>    qcow2_format.py: pass cluster size to substructures
>    qcow2_format.py: Dump bitmap table serialized entries
>    qcow2.py: Introduce '-j' key to dump in JSON format
>    qcow2_format.py: collect fields to dump in JSON format
>    qcow2_format.py: support dumping metadata in JSON format
>    iotests: dump QCOW2 header in JSON in #303
>
>   tests/qemu-iotests/303             |  63 +++++++++++
>   tests/qemu-iotests/303.out         | 158 +++++++++++++++++++++++++++
>   tests/qemu-iotests/group           |   1 +
>   tests/qemu-iotests/qcow2.py        |  18 +++-
>   tests/qemu-iotests/qcow2_format.py | 215 ++++++++++++++++++++++++++++++++++---
>   5 files changed, 434 insertions(+), 21 deletions(-)
>   create mode 100755 tests/qemu-iotests/303
>   create mode 100644 tests/qemu-iotests/303.out