[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/41] aspeed_timer: Fix ASPEED_TIMER macro definition
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 05/41] aspeed_timer: Fix ASPEED_TIMER macro definition |
Date: |
Fri, 14 Aug 2020 19:47:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 8/14/20 12:25 AM, Eduardo Habkost wrote:
> The macro definition had an extra semicolon. This was never
> noticed because the macro was only being used where it didn't
> make a difference.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> include/hw/timer/aspeed_timer.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/timer/aspeed_timer.h b/include/hw/timer/aspeed_timer.h
> index 948329893c..d7c7d8ad28 100644
> --- a/include/hw/timer/aspeed_timer.h
> +++ b/include/hw/timer/aspeed_timer.h
> @@ -26,7 +26,7 @@
> #include "hw/misc/aspeed_scu.h"
>
> #define ASPEED_TIMER(obj) \
> - OBJECT_CHECK(AspeedTimerCtrlState, (obj), TYPE_ASPEED_TIMER);
> + OBJECT_CHECK(AspeedTimerCtrlState, (obj), TYPE_ASPEED_TIMER)
> #define TYPE_ASPEED_TIMER "aspeed.timer"
> #define TYPE_ASPEED_2400_TIMER TYPE_ASPEED_TIMER "-ast2400"
> #define TYPE_ASPEED_2500_TIMER TYPE_ASPEED_TIMER "-ast2500"
>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH 00/41] qom: Automated conversion of type checking boilerplate, Eduardo Habkost, 2020/08/13
- [PATCH 01/41] pl1110: Rename PL1110 enum, Eduardo Habkost, 2020/08/13
- [PATCH 03/41] megasas: Rename QOM class cast macros, Eduardo Habkost, 2020/08/13
- [PATCH 04/41] vmw_pvscsi: Rename QOM class cast macros, Eduardo Habkost, 2020/08/13
- [PATCH 05/41] aspeed_timer: Fix ASPEED_TIMER macro definition, Eduardo Habkost, 2020/08/13
- [PATCH 02/41] e1000: Rename QOM class cast macros, Eduardo Habkost, 2020/08/13
- [PATCH 06/41] allwinner-h3: Rename memmap enum constants, Eduardo Habkost, 2020/08/13
- [PATCH 09/41] sifive_e: Rename memmap enum constants, Eduardo Habkost, 2020/08/13
- [PATCH 10/41] sifive_u: Rename memmap enum constants, Eduardo Habkost, 2020/08/13