[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa
From: |
Daniel Henrique Barboza |
Subject: |
[PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa |
Date: |
Fri, 14 Aug 2020 17:54:16 -0300 |
The pSeries machine does not support asymmetrical NUMA configurations.
CC: Eduardo Habkost <ehabkost@redhat.com>
CC: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
hw/core/numa.c | 7 +++++++
hw/ppc/spapr.c | 1 +
include/hw/boards.h | 1 +
3 files changed, 9 insertions(+)
diff --git a/hw/core/numa.c b/hw/core/numa.c
index d1a94a14f8..1e81233c1d 100644
--- a/hw/core/numa.c
+++ b/hw/core/numa.c
@@ -547,6 +547,7 @@ static int parse_numa(void *opaque, QemuOpts *opts, Error
**errp)
*/
static void validate_numa_distance(MachineState *ms)
{
+ MachineClass *mc = MACHINE_GET_CLASS(ms);
int src, dst;
bool is_asymmetrical = false;
int nb_numa_nodes = ms->numa_state->num_nodes;
@@ -575,6 +576,12 @@ static void validate_numa_distance(MachineState *ms)
}
if (is_asymmetrical) {
+ if (mc->forbid_asymmetrical_numa) {
+ error_report("This machine type does not support "
+ "asymmetrical numa distances.");
+ exit(EXIT_FAILURE);
+ }
+
for (src = 0; src < nb_numa_nodes; src++) {
for (dst = 0; dst < nb_numa_nodes; dst++) {
if (src != dst && numa_info[src].distance[dst] == 0) {
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index dd2fa4826b..3b16edaf4c 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -4512,6 +4512,7 @@ static void spapr_machine_class_init(ObjectClass *oc,
void *data)
*/
mc->numa_mem_align_shift = 28;
mc->auto_enable_numa = true;
+ mc->forbid_asymmetrical_numa = true;
smc->default_caps.caps[SPAPR_CAP_HTM] = SPAPR_CAP_OFF;
smc->default_caps.caps[SPAPR_CAP_VSX] = SPAPR_CAP_ON;
diff --git a/include/hw/boards.h b/include/hw/boards.h
index bc5b82ad20..dc6cdd1c53 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -215,6 +215,7 @@ struct MachineClass {
bool nvdimm_supported;
bool numa_mem_supported;
bool auto_enable_numa;
+ bool forbid_asymmetrical_numa;
const char *default_ram_id;
HotplugHandler *(*get_hotplug_handler)(MachineState *machine,
--
2.26.2
- [PATCH 07/10] spapr: create helper to set ibm,associativity, (continued)
- [PATCH 07/10] spapr: create helper to set ibm,associativity, Daniel Henrique Barboza, 2020/08/15
- [PATCH 04/10] spapr: add spapr_machine_using_legacy_numa() helper, Daniel Henrique Barboza, 2020/08/15
- [PATCH 06/10] spapr: allow 4 NUMA levels in ibm, associativity-reference-points, Daniel Henrique Barboza, 2020/08/15
- [PATCH 10/10] specs/ppc-spapr-numa: update with new NUMA support, Daniel Henrique Barboza, 2020/08/15
- [PATCH 05/10] spapr: make ibm, max-associativity-domains scale with user input, Daniel Henrique Barboza, 2020/08/15
- [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa,
Daniel Henrique Barboza <=
- Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa, David Gibson, 2020/08/19
- Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa, Eduardo Habkost, 2020/08/20
- Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa, Igor Mammedov, 2020/08/21
- Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa, Daniel Henrique Barboza, 2020/08/21
- Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa, David Gibson, 2020/08/24
- Re: [PATCH 02/10] numa: introduce MachineClass::forbid_asymmetrical_numa, Daniel Henrique Barboza, 2020/08/24