[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 10/22] nbd: Remove NBDExport.close callback
From: |
Max Reitz |
Subject: |
Re: [RFC PATCH 10/22] nbd: Remove NBDExport.close callback |
Date: |
Mon, 17 Aug 2020 16:02:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 13.08.20 18:29, Kevin Wolf wrote:
> The export close callback is unused by the built-in NBD server. qemu-nbd
> uses it only during shutdown to wait for the unrefed export to actually
> go away. It can just use nbd_export_close_all() instead and do without
> the callback.
>
> This removes the close callback from nbd_export_new() and makes both
> callers of it more similar.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> include/block/nbd.h | 3 +--
> blockdev-nbd.c | 2 +-
> nbd/server.c | 9 +--------
> qemu-nbd.c | 14 ++++----------
> 4 files changed, 7 insertions(+), 21 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
signature.asc
Description: OpenPGP digital signature
- Re: [RFC PATCH 07/22] block/export: Remove magic from block-export-add, (continued)
[RFC PATCH 08/22] nbd: Add max-connections to nbd-server-start, Kevin Wolf, 2020/08/13
[RFC PATCH 10/22] nbd: Remove NBDExport.close callback, Kevin Wolf, 2020/08/13
[RFC PATCH 11/22] qemu-nbd: Use blk_exp_add() to create the export, Kevin Wolf, 2020/08/13
[RFC PATCH 13/22] block/export: Move refcount from NBDExport to BlockExport, Kevin Wolf, 2020/08/13