Re: [PATCH 04/17] crypto: Rename cipher include files to .inc.c

[Daniel P . Berrangé]

On Thu, Aug 13, 2020 at 10:00:29AM +0200, Philippe Mathieu-Daudé wrote:
> On 8/13/20 5:25 AM, Richard Henderson wrote:
> > QEMU standard procedure for included c files is to use *.inc.c.
> > E.g. there are a different set of checks that are applied.
> > 
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> >  crypto/{cipher-builtin.c => cipher-builtin.inc.c} | 0
> >  crypto/{cipher-gcrypt.c => cipher-gcrypt.inc.c}   | 0
> >  crypto/{cipher-nettle.c => cipher-nettle.inc.c}   | 0
> >  crypto/cipher.c                                   | 6 +++---
> >  4 files changed, 3 insertions(+), 3 deletions(-)
> >  rename crypto/{cipher-builtin.c => cipher-builtin.inc.c} (100%)
> >  rename crypto/{cipher-gcrypt.c => cipher-gcrypt.inc.c} (100%)
> >  rename crypto/{cipher-nettle.c => cipher-nettle.inc.c} (100%)
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> (This clashes with Paolo's Meson series renaming them to .c.inc).

IIRC, we need to use  c.inc, because Meson has specific semantics
around a file ending in ".c" that we don't want.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|