[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.1 v2 0/2] stubs: Fix notify-event stub linkage error on
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH-for-5.1 v2 0/2] stubs: Fix notify-event stub linkage error on MinGW |
Date: |
Tue, 18 Aug 2020 08:37:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 |
On 05/08/20 10:55, Philippe Mathieu-Daudé wrote:
> 2 trivial patches to fix the link error reported by Thomas:
>
> LINK tests/test-timed-average.exe
> libqemuutil.a(main-loop.o): In function `qemu_notify_event':
> util/main-loop.c:139: multiple definition of `qemu_notify_event'
>
> tests/test-timed-average.o:/builds/huth/qemu/tests/../stubs/notify-event.c:5:
> first defined here
> collect2: error: ld returned 1 exit status
> rules.mak:124: recipe for target 'tests/test-timed-average.exe' failed
>
> Philippe Mathieu-Daudé (2):
> exec: Restrict icount to softmmu
> stubs: Remove qemu_notify_event()
>
> include/sysemu/cpus.h | 4 ++++
> exec.c | 4 ----
> softmmu/cpus.c | 7 +++++++
> stubs/cpu-get-icount.c | 2 +-
> stubs/notify-event.c | 6 ------
> stubs/Makefile.objs | 1 -
> 6 files changed, 12 insertions(+), 12 deletions(-)
> delete mode 100644 stubs/notify-event.c
>
Patch 1 will be superseded by Claudio's refactoring. For patch 2 please
respin according to the review.
Paolo
Re: [PATCH-for-5.1 v2 0/2] stubs: Fix notify-event stub linkage error on MinGW,
Paolo Bonzini <=