Re: [PATCH v2] audio/jack: fix use after free segfault

[Geoffrey McRae]

On 2020-08-19 15:04, Gerd Hoffmann wrote:
> Hi,
>
> > As JACK1 and JACK2 are interchangeable and JACK2 has "cleanup" routine
> > that JACK1 does not have, we need to determine which version is in use
> > at runtime. Unfortunatly there is no way to determine which is in use
> > other then to look for symbols that are missing in JACK1, which in 
> > this
> > case is `jack_get_version`.
>
> No.  That'll quickly becomes a maintainance nightmare.
>
> How about moving the qjack_client_fini() call to qjack_shutdown()?  Or,
> if that isn't an option due to qjack_shutdown being called from a 
> signal
> handler, schedule a bottom half calling qjack_client_fini()?

You are correct, you can not perform such actions in the callback.

> schedule a bottom half calling qjack_client_fini()

Does QEMU have such a mechanism for doing this?

> take care,
>   Gerd