[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 01/15] fuzz: Change the way we write qtest log to stderr
From: |
Alexander Bulekov |
Subject: |
[PATCH v2 01/15] fuzz: Change the way we write qtest log to stderr |
Date: |
Wed, 19 Aug 2020 02:10:56 -0400 |
Telling QTest to log to /dev/fd/2, essentially results in dup(2). This
is fine, if other code isn't logging to stderr. Otherwise, the order of
the logs is mixed due to buffering issues, since two file-descriptors
are used to write to the same file. We can avoid this, since just
specifying "-qtest" sets the log fd to stderr. If we want to disable
qtest logs, we can just add -qtest-log none.
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
---
tests/qtest/fuzz/fuzz.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tests/qtest/fuzz/fuzz.c b/tests/qtest/fuzz/fuzz.c
index 031594a686..8234b68754 100644
--- a/tests/qtest/fuzz/fuzz.c
+++ b/tests/qtest/fuzz/fuzz.c
@@ -202,9 +202,8 @@ int LLVMFuzzerInitialize(int *argc, char ***argv, char
***envp)
/* Run QEMU's softmmu main with the fuzz-target dependent arguments */
GString *cmd_line = fuzz_target->get_init_cmdline(fuzz_target);
- g_string_append_printf(cmd_line,
- " -qtest /dev/null -qtest-log %s",
- getenv("QTEST_LOG") ? "/dev/fd/2" : "/dev/null");
+ g_string_append_printf(cmd_line, " %s -qtest /dev/null ",
+ getenv("QTEST_LOG") ? "" : "-qtest-log none");
/* Split the runcmd into an argv and argc */
wordexp_t result;
--
2.27.0
- [PATCH v2 00/15] Add a General Virtual Device Fuzzer, Alexander Bulekov, 2020/08/19
- [PATCH v2 01/15] fuzz: Change the way we write qtest log to stderr,
Alexander Bulekov <=
- [PATCH v2 02/15] fuzz: Add general virtual-device fuzzer, Alexander Bulekov, 2020/08/19
- [PATCH v2 08/15] fuzz: add a DISABLE_PCI op to general-fuzzer, Alexander Bulekov, 2020/08/19
- [PATCH v2 03/15] fuzz: Add PCI features to the general fuzzer, Alexander Bulekov, 2020/08/19
- [PATCH v2 09/15] fuzz: add a crossover function to generic-fuzzer, Alexander Bulekov, 2020/08/19
- [PATCH v2 04/15] fuzz: Add DMA support to the generic-fuzzer, Alexander Bulekov, 2020/08/19
- [PATCH v2 10/15] scripts/oss-fuzz: Add wrapper program for generic fuzzer, Alexander Bulekov, 2020/08/19
- [PATCH v2 11/15] scripts/oss-fuzz: Add general-fuzzer build script, Alexander Bulekov, 2020/08/19
- [PATCH v2 05/15] fuzz: Declare DMA Read callback function, Alexander Bulekov, 2020/08/19
- [PATCH v2 06/15] fuzz: Add fuzzer callbacks to DMA-read functions, Alexander Bulekov, 2020/08/19
- [PATCH v2 13/15] scripts/oss-fuzz: build the general-fuzzer configs, Alexander Bulekov, 2020/08/19