[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: docker: support mxe-based mingw builds
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH] tests: docker: support mxe-based mingw builds |
Date: |
Wed, 19 Aug 2020 12:42:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 |
On 19/08/20 10:20, Daniel P. Berrangé wrote:
> We already have docker containers with MXE based on Debian:
>
> debian-win32-cross.docker
> debian-win64-cross.docker
>
> your image uses a different naming convention, and puts both
> 32 and 64 bit in the same image.
Yeah, that's what test-mingw expects.
> I feel like we should have the Ubuntu variant follow the same
> structure and naming as the Debian variant for consistency.
My patch follows the Fedora variant, so that test-mingw runs. That
ensures that NSIS is covered as well. One possibility could be:
- create fedora-win*-cross dockerfiles
- add ENV FEATURES $FEATURES mingw to the win*-cross dockerfiles
- look for the feature in test-full and test-quick, and run "make
installer" if so.
- drop test-mingw completely, and adjust Patchew to use
docker-test-quick@fedora-win{32,64}-cross instead
Paolo