Re: [PATCH v7 27/47] blkverify: Use bdrv_sum_allocated_file_size()

[Kevin Wolf]

Am 25.06.2020 um 17:21 hat Max Reitz geschrieben:
> blkverify is a filter, so bdrv_get_allocated_file_size()'s default
> implementation will return only the size of its filtered child.
> However, because both of its children are disk images, it makes more
> sense to sum both of their allocated sizes.

Hm, but so are the children of, say, backup-top. I don't think you're
suggesting that backup-top should add the sizes of both images, even
though the backup job is actively increasing the allocated size of the
non-primary node, much like blkverify.

So I believe returning only the allocated size of the primary child in
blkverify would be more consistent with what we do elsewhere.

Kevin