[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 7/8] sparc/sun4m: Use start-powered-off CPUState property
From: |
Thiago Jung Bauermann |
Subject: |
Re: [PATCH v6 7/8] sparc/sun4m: Use start-powered-off CPUState property |
Date: |
Wed, 19 Aug 2020 20:54:33 -0300 |
User-agent: |
mu4e 1.2.0; emacs 26.3 |
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> On 8/19/20 6:43 PM, Thiago Jung Bauermann wrote:
>> Instead of setting CPUState::halted to 1 in secondary_cpu_reset(), use the
>> start-powered-off property which makes cpu_common_reset() initialize it
>> to 1 in common code.
>>
>> This makes secondary_cpu_reset() unnecessary, so remove it.
>>
>> Also remove setting of cs->halted from cpu_devinit(), which seems out of
>> place when compared to similar code in other architectures (e.g.,
>> ppce500_init() in hw/ppc/e500.c).
>>
>> Finally, change creation of CPU object from cpu_create() to object_new()
>> and qdev_realize_and_unref() because cpu_create() realizes the CPU and it's
>> not possible to set a property after the object is realized.
>>
>> Suggested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Thanks!
--
Thiago Jung Bauermann
IBM Linux Technology Center
- [PATCH v6 0/8] Generalize start-powered-off property from ARM, Thiago Jung Bauermann, 2020/08/19
- [PATCH v6 2/8] target/arm: Move setting of CPU halted state to generic code, Thiago Jung Bauermann, 2020/08/19
- [PATCH v6 1/8] target/arm: Move start-powered-off property to generic CPUState, Thiago Jung Bauermann, 2020/08/19
- [PATCH v6 3/8] ppc/spapr: Use start-powered-off CPUState property, Thiago Jung Bauermann, 2020/08/19
- [PATCH v6 4/8] ppc/e500: Use start-powered-off CPUState property, Thiago Jung Bauermann, 2020/08/19
- [PATCH v6 5/8] mips/cps: Use start-powered-off CPUState property, Thiago Jung Bauermann, 2020/08/19
- [PATCH v6 6/8] sparc/sun4m: Remove main_cpu_reset(), Thiago Jung Bauermann, 2020/08/19
- [PATCH v6 7/8] sparc/sun4m: Use start-powered-off CPUState property, Thiago Jung Bauermann, 2020/08/19
- [PATCH v6 8/8] target/s390x: Use start-powered-off CPUState property, Thiago Jung Bauermann, 2020/08/19
- Re: [PATCH v6 0/8] Generalize start-powered-off property from ARM, David Gibson, 2020/08/19