[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 10/58] aspeed_timer: Fix ASPEED_TIMER macro definition
From: |
Cédric Le Goater |
Subject: |
Re: [PATCH v2 10/58] aspeed_timer: Fix ASPEED_TIMER macro definition |
Date: |
Thu, 20 Aug 2020 08:42:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 8/20/20 2:11 AM, Eduardo Habkost wrote:
> The macro definition had an extra semicolon. This was never
> noticed because the macro was only being used where it didn't
> make a difference.
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
> ---
> Changes v1 -> v2: none
>
> ---
> Cc: "Cédric Le Goater" <clg@kaod.org>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: qemu-arm@nongnu.org
> Cc: qemu-devel@nongnu.org
> ---
> include/hw/timer/aspeed_timer.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/timer/aspeed_timer.h b/include/hw/timer/aspeed_timer.h
> index 948329893c..d7c7d8ad28 100644
> --- a/include/hw/timer/aspeed_timer.h
> +++ b/include/hw/timer/aspeed_timer.h
> @@ -26,7 +26,7 @@
> #include "hw/misc/aspeed_scu.h"
>
> #define ASPEED_TIMER(obj) \
> - OBJECT_CHECK(AspeedTimerCtrlState, (obj), TYPE_ASPEED_TIMER);
> + OBJECT_CHECK(AspeedTimerCtrlState, (obj), TYPE_ASPEED_TIMER)
> #define TYPE_ASPEED_TIMER "aspeed.timer"
> #define TYPE_ASPEED_2400_TIMER TYPE_ASPEED_TIMER "-ast2400"
> #define TYPE_ASPEED_2500_TIMER TYPE_ASPEED_TIMER "-ast2500"
>
- Re: [PATCH v2 04/58] pl110: Rename pl110_version enum values, (continued)
- [PATCH v2 02/58] megasas: Rename QOM class cast macros, Eduardo Habkost, 2020/08/19
- [PATCH v2 03/58] vmw_pvscsi: Rename QOM class cast macros, Eduardo Habkost, 2020/08/19
- [PATCH v2 05/58] allwinner-h3: Rename memmap enum constants, Eduardo Habkost, 2020/08/19
- [PATCH v2 06/58] aspeed_soc: Rename memmap/irqmap enum constants, Eduardo Habkost, 2020/08/19
- [PATCH v2 08/58] sifive_e: Rename memmap enum constants, Eduardo Habkost, 2020/08/19
- [PATCH v2 07/58] opentitan: Rename memmap enum constants, Eduardo Habkost, 2020/08/19
- [PATCH v2 09/58] sifive_u: Rename memmap enum constants, Eduardo Habkost, 2020/08/19
- [PATCH v2 10/58] aspeed_timer: Fix ASPEED_TIMER macro definition, Eduardo Habkost, 2020/08/19
- Re: [PATCH v2 10/58] aspeed_timer: Fix ASPEED_TIMER macro definition,
Cédric Le Goater <=
- [PATCH v2 11/58] versatile: Fix typo in PCI_VPB_HOST definition, Eduardo Habkost, 2020/08/19
- [PATCH v2 12/58] virtio-ccw: Fix definition of VIRTIO_CCW_BUS_GET_CLASS, Eduardo Habkost, 2020/08/19
- [PATCH v2 13/58] hvf: Add missing include, Eduardo Habkost, 2020/08/19
- [PATCH v2 14/58] hcd-dwc2: Rename USB_*CLASS macros for consistency, Eduardo Habkost, 2020/08/19
- [PATCH v2 15/58] tulip: Move TulipState typedef to header, Eduardo Habkost, 2020/08/19
- [PATCH v2 16/58] throttle-groups: Move ThrottleGroup typedef to header, Eduardo Habkost, 2020/08/19
- [PATCH v2 17/58] pci: Move PCIBusClass typedef to pci.h, Eduardo Habkost, 2020/08/19
- [PATCH v2 18/58] i8254: Move PITCommonState/PITCommonClass typedefs to i8254.h, Eduardo Habkost, 2020/08/19
- [PATCH v2 19/58] hvf: Move HVFState typedef to hvf.h, Eduardo Habkost, 2020/08/19