[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 23/58] nubus: Delete unused NUBUS_BRIDGE macro
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v2 23/58] nubus: Delete unused NUBUS_BRIDGE macro |
Date: |
Thu, 20 Aug 2020 17:05:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
Le 20/08/2020 à 02:12, Eduardo Habkost a écrit :
> The macro never worked because the NubusBridge typedef doesn't
> exist. Delete it.
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Changes v1 -> v2: none
>
> ---
> Cc: Laurent Vivier <laurent@vivier.eu>
> Cc: qemu-devel@nongnu.org
> ---
> include/hw/nubus/nubus.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/hw/nubus/nubus.h b/include/hw/nubus/nubus.h
> index a8634e54c5..c350948262 100644
> --- a/include/hw/nubus/nubus.h
> +++ b/include/hw/nubus/nubus.h
> @@ -29,7 +29,6 @@
> #define NUBUS_BUS(obj) OBJECT_CHECK(NubusBus, (obj), TYPE_NUBUS_BUS)
>
> #define TYPE_NUBUS_BRIDGE "nubus-bridge"
> -#define NUBUS_BRIDGE(obj) OBJECT_CHECK(NubusBridge, (obj), TYPE_NUBUS_BRIDGE)
>
> typedef struct NubusBus {
> BusState qbus;
>
Acked-by: Laurent Vivier <laurent@vivier.eu>
- [PATCH v2 16/58] throttle-groups: Move ThrottleGroup typedef to header, (continued)
- [PATCH v2 16/58] throttle-groups: Move ThrottleGroup typedef to header, Eduardo Habkost, 2020/08/19
- [PATCH v2 17/58] pci: Move PCIBusClass typedef to pci.h, Eduardo Habkost, 2020/08/19
- [PATCH v2 18/58] i8254: Move PITCommonState/PITCommonClass typedefs to i8254.h, Eduardo Habkost, 2020/08/19
- [PATCH v2 19/58] hvf: Move HVFState typedef to hvf.h, Eduardo Habkost, 2020/08/19
- [PATCH v2 20/58] mcf_fec: Move mcf_fec_state typedef to header, Eduardo Habkost, 2020/08/19
- [PATCH v2 22/58] can_emu: Delete macros for non-existing typedef, Eduardo Habkost, 2020/08/19
- [PATCH v2 21/58] s390_flic: Move KVMS390FLICState typedef to header, Eduardo Habkost, 2020/08/19
- [PATCH v2 23/58] nubus: Delete unused NUBUS_BRIDGE macro, Eduardo Habkost, 2020/08/19
- Re: [PATCH v2 23/58] nubus: Delete unused NUBUS_BRIDGE macro,
Laurent Vivier <=
- [PATCH v2 25/58] armsse: Rename QOM macros to avoid conflicts, Eduardo Habkost, 2020/08/19
- [PATCH v2 24/58] platform-bus: Delete macros for non-existing typedef, Eduardo Habkost, 2020/08/19
- [PATCH v2 26/58] xen-legacy-backend: Add missing typedef XenLegacyDevice, Eduardo Habkost, 2020/08/19
- [PATCH v2 27/58] spapr: Move typedef SpaprMachineState to spapr.h, Eduardo Habkost, 2020/08/19
- [PATCH v2 28/58] s390x: Move typedef SCLPEventFacility to event-facility.h, Eduardo Habkost, 2020/08/19