Re: [PATCH] util/vfio-helpers: Unify trace-events size format

[Cornelia Huck]

On Thu, 20 Aug 2020 19:10:06 +0200
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:

> Some 'qemu_vfio_*' trace events sizes are displayed using
> decimal notation, other using hexadecimal notation:
> 
>   qemu_vfio_ram_block_added s 0xaaaaf2448d90 host 0xffff5bc00000 size 
> 0x4000000
>   qemu_vfio_dma_map s 0xaaaaf2448d90 host 0xffff5bc00000 size 67108864 
> temporary 0 iova (nil)
>   qemu_vfio_find_mapping s 0xaaaaf2448d90 host 0xffff5bc00000
>   qemu_vfio_new_mapping s 0xaaaaf2448d90 host 0xffff5bc00000 size 67108864 
> index 4 iova 0x114000
>   qemu_vfio_do_mapping s 0xaaaaf2448d90 host 0xffff5bc00000 size 67108864 
> iova 0x114000
> 
> As it is hard to follow, unify using hexadecimal for all sizes:
> 
>   qemu_vfio_ram_block_added s 0xaaaaf1c60d90 host 0xffff2bc00000 size 
> 0x4000000
>   qemu_vfio_dma_map s 0xaaaaf1c60d90 host 0xffff2bc00000 size 0x4000000 
> temporary 0 iova (nil)
>   qemu_vfio_find_mapping s 0xaaaaf1c60d90 host 0xffff2bc00000
>   qemu_vfio_new_mapping s 0xaaaaf1c60d90 host 0xffff2bc00000 size 0x4000000 
> index 4 iova 0x114000
>   qemu_vfio_do_mapping s 0xaaaaf1c60d90 host 0xffff2bc00000 size 0x4000000 
> iova 0x114000
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  util/trace-events | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>