Re: [PATCH v2] configure: add support for pseudo-"in source tree" builds

[Daniel P . Berrangé]

On Fri, Aug 21, 2020 at 12:17:53PM +0200, Kevin Wolf wrote:
> Am 20.08.2020 um 19:31 hat Daniel P. Berrangé geschrieben:
> > Meson requires the build dir to be separate from the source tree. Many
> > people are used to just running "./configure && make" though and the
> > meson conversion breaks that.
> > 
> > This introduces some backcompat support to make it appear as if an
> > "in source tree" build is being done, but with the the results in the
> > "build/" directory. This allows "./configure && make" to work as it
> > did historically, albeit with the output binaries staying under build/.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> > 
> > This is a simple integration of Eric's proposal from
> > 
> >   https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg07290.html
> > 
> > with a bit of configure magic. It is enough to enable
> > 
> >    ./configure
> >    make
> >    make check
> > 
> > I've not tested it beyond that. Note it blows away the "build/"
> > dir each time ./configure is run so it is pristine each time.
> 
> I guess "make install" is the only other one that normal users would
> care about. We shoud make sure that it works (I don't see why it
> wouldn't, but worth testing anyway).

I've just tested  "make instal DESTDIR=`pwd`/vroot" in order to
validate that variables are passed through too, and it appears to
be succesful.

$  make install DESTDIR=`pwd`/vroot
...snip...
$ find vroot/ | head -30
vroot/
vroot/usr
vroot/usr/local
vroot/usr/local/bin
vroot/usr/local/bin/qemu-nbd
vroot/usr/local/bin/qemu-keymap
vroot/usr/local/bin/qemu-pr-helper
vroot/usr/local/bin/qemu-storage-daemon
vroot/usr/local/bin/elf2dmp
vroot/usr/local/bin/qemu-img
vroot/usr/local/bin/qemu-edid
vroot/usr/local/bin/qemu-system-x86_64
vroot/usr/local/bin/qemu-ga
vroot/usr/local/bin/qemu-io
vroot/usr/local/var
vroot/usr/local/var/run
vroot/usr/local/libexec
vroot/usr/local/libexec/vhost-user-gpu
vroot/usr/local/libexec/qemu-bridge-helper
vroot/usr/local/libexec/virtfs-proxy-helper
vroot/usr/local/libexec/virtiofsd
vroot/usr/local/share
vroot/usr/local/share/icons
vroot/usr/local/share/icons/hicolor
vroot/usr/local/share/icons/hicolor/256x256
vroot/usr/local/share/icons/hicolor/256x256/apps
vroot/usr/local/share/icons/hicolor/256x256/apps/qemu.png
vroot/usr/local/share/icons/hicolor/48x48
vroot/usr/local/share/icons/hicolor/48x48/apps
vroot/usr/local/share/icons/hicolor/48x48/apps/qemu.png
...snip...

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|