Re: [PATCH] hw/arm/sbsa-ref: fix typo breaking PCIe IRQs

[Philippe Mathieu-Daudé]

On 8/21/20 10:38 AM, Graeme Gregory wrote:
> Fixing a typo in a previous patch that translated an "i" to a 1
> and therefore breaking the allocation of PCIe interrupts. This was
> discovered when virtio-net-pci devices ceased to function correctly.
> 
> Fixes: 48ba18e6d3f3 ("hw/arm/sbsa-ref: Simplify by moving the gic in the 
> machine state")
> Signed-off-by: Graeme Gregory <graeme@nuviainc.com>
> ---
>  hw/arm/sbsa-ref.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
> index 570faac6e2..48c7cea291 100644
> --- a/hw/arm/sbsa-ref.c
> +++ b/hw/arm/sbsa-ref.c
> @@ -565,7 +565,7 @@ static void create_pcie(SBSAMachineState *sms)
>  
>      for (i = 0; i < GPEX_NUM_IRQS; i++) {
>          sysbus_connect_irq(SYS_BUS_DEVICE(dev), i,
> -                           qdev_get_gpio_in(sms->gic, irq + 1));
> +                           qdev_get_gpio_in(sms->gic, irq + i));

Oops...
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

>          gpex_set_irq_num(GPEX_HOST(dev), i, irq + i);
>      }
>  
>