[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/2] meson: convert pc-bios/keymaps/Makefile
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH v3 1/2] meson: convert pc-bios/keymaps/Makefile |
Date: |
Mon, 24 Aug 2020 07:23:36 +0200 |
> --- a/pc-bios/meson.build
> +++ b/pc-bios/meson.build
> @@ -25,3 +25,4 @@ if 'DECOMPRESS_EDK2_BLOBS' in config_host
> endif
>
> subdir('descriptors')
> +subdir('keymaps')
Hmm, this hooks up the keymaps update to the default build.
Not a good plan. The output is not static, but defaults on
the libxkbcommon version you have installed. So I end up with
a dirty tree now after each build.
I guess we should either return to the traditional behavior of not
building keymaps by default and have a "make keymaps" or similar for
keymap updates. Or write the generated maps to the build tree not
the source tree.
take care,
Gerd