[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 02/10] hw/arm/omap1:Remove redundant statement in omap_clkdsp_
From: |
Chen Qun |
Subject: |
[PATCH v3 02/10] hw/arm/omap1:Remove redundant statement in omap_clkdsp_read() |
Date: |
Thu, 27 Aug 2020 19:03:03 +0800 |
Clang static code analyzer show warning:
hw/arm/omap1.c:1760:15: warning: Value stored to 'cpu' during its
initialization is never read
CPUState *cpu = CPU(s->cpu);
^~~ ~~~~~~~~~~~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
---
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm@nongnu.org
---
hw/arm/omap1.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/arm/omap1.c b/hw/arm/omap1.c
index 6ba0df6b6d..02c0f66431 100644
--- a/hw/arm/omap1.c
+++ b/hw/arm/omap1.c
@@ -1774,7 +1774,6 @@ static uint64_t omap_clkdsp_read(void *opaque, hwaddr
addr,
return s->clkm.dsp_rstct2;
case 0x18: /* DSP_SYSST */
- cpu = CPU(s->cpu);
return (s->clkm.clocking_scheme << 11) | s->clkm.cold_start |
(cpu->halted << 6); /* Quite useless... */
}
--
2.23.0
- [PATCH v3 00/10] trivial patchs for static code analyzer fixes, Chen Qun, 2020/08/27
- [PATCH v3 04/10] target/arm/translate-a64:Remove redundant statement in disas_simd_two_reg_misc_fp16(), Chen Qun, 2020/08/27
- [PATCH v3 01/10] hw/arm/virt-acpi-build:Remove dead assignment in build_madt(), Chen Qun, 2020/08/27
- [PATCH v3 03/10] target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli(), Chen Qun, 2020/08/27
- [PATCH v3 07/10] vfio/platform: Remove dead assignment in vfio_intp_interrupt(), Chen Qun, 2020/08/27
- [PATCH v3 02/10] hw/arm/omap1:Remove redundant statement in omap_clkdsp_read(),
Chen Qun <=
- [PATCH v3 06/10] hw/net/virtio-net:Remove redundant statement in virtio_net_rsc_tcp_ctrl_check(), Chen Qun, 2020/08/27
- [PATCH v3 05/10] hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions(), Chen Qun, 2020/08/27
- [PATCH v3 09/10] hw/intc: fix default registers value in exynos4210_combiner_read(), Chen Qun, 2020/08/27
- [PATCH v3 10/10] hw/display/vga:Remove redundant statement in vga_draw_graphic(), Chen Qun, 2020/08/27
- [PATCH v3 08/10] usb/bus: Remove dead assignment in usb_get_fw_dev_path(), Chen Qun, 2020/08/27