[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 66/77] target/microblaze: Use tcg_gen_lookup_and_goto_ptr
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH 66/77] target/microblaze: Use tcg_gen_lookup_and_goto_ptr |
|
Date: |
Fri, 28 Aug 2020 06:32:56 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 8/27/20 11:33 PM, Edgar E. Iglesias wrote:
> On Tue, Aug 25, 2020 at 01:59:39PM -0700, Richard Henderson wrote:
>> When goto_tb cannot be used due to branch page crossing,
>> or due to indirect jumping, tcg_gen_lookup_and_goto_ptr
>> can be used instead.
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>
> Hi Richard,
>
> This patch is for some reason causing some of our tests to fail.
> The PMU Firmware on the ZynqMP gets stuck.
> Looking at logs nothing obvious shows up, it just gets stuck.
> Bisected it to this patch, any ideas?
Failure to raise an exception properly, I think. This patch makes it much less
likely to return to the main cpu loop.
The problem with the bisection, I think, is that this patch is in the middle.
It might be worthwhile to apply it directly to master and see what happens.
That said, I don't see what we could have missed in translate, setting
cpustate_changed...
r~
- Re: [PATCH 62/77] target/microblaze: Try to keep imm and delay slot together, (continued)
[PATCH 65/77] target/microblaze: Reorganize branching, Richard Henderson, 2020/08/25
[PATCH 66/77] target/microblaze: Use tcg_gen_lookup_and_goto_ptr, Richard Henderson, 2020/08/25
[PATCH 67/77] target/microblaze: Convert dec_br to decodetree, Richard Henderson, 2020/08/25
[PATCH 69/77] target/microblaze: Convert dec_rts to decodetree, Richard Henderson, 2020/08/25
[PATCH 68/77] target/microblaze: Convert dec_bcc to decodetree, Richard Henderson, 2020/08/25
[PATCH 73/77] target/microblaze: Convert dec_stream to decodetree, Richard Henderson, 2020/08/25
[PATCH 72/77] target/microblaze: Convert dec_msr to decodetree, Richard Henderson, 2020/08/25
[PATCH 76/77] target/microblaze: Add flags markup to some helpers, Richard Henderson, 2020/08/25
[PATCH 70/77] target/microblaze: Tidy do_rti, do_rtb, do_rte, Richard Henderson, 2020/08/25
[PATCH 75/77] target/microblaze: Remove cpu_R[0], Richard Henderson, 2020/08/25