Re: [PATCH v5 2/8] util: split off a helper for dealing with O

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 2/8] util: split off a helper for dealing with O_CLOEXEC f

From:	Markus Armbruster
Subject:	Re: [PATCH v5 2/8] util: split off a helper for dealing with O_CLOEXEC flag
Date:	Thu, 03 Sep 2020 10:53:29 +0200
User-agent:	Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Daniel P. Berrangé <berrange@redhat.com> writes:

> We're going to have multiple callers to open() from qemu_open()
> soon. Readability would thus benefit from having a helper for
> dealing with O_CLOEXEC.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v5 0/8] block: improve error reporting for unsupported O_DIRECT, Daniel P . Berrangé, 2020/09/02
- [PATCH v5 1/8] monitor: simplify functions for getting a dup'd fdset entry, Daniel P . Berrangé, 2020/09/02
  - Re: [PATCH v5 1/8] monitor: simplify functions for getting a dup'd fdset entry, Markus Armbruster, 2020/09/03
    - Re: [PATCH v5 1/8] monitor: simplify functions for getting a dup'd fdset entry, Daniel P . Berrangé, 2020/09/03
- [PATCH v5 2/8] util: split off a helper for dealing with O_CLOEXEC flag, Daniel P . Berrangé, 2020/09/02
  - Re: [PATCH v5 2/8] util: split off a helper for dealing with O_CLOEXEC flag, Markus Armbruster <=
- [PATCH v5 3/8] util: rename qemu_open() to qemu_open_old(), Daniel P . Berrangé, 2020/09/02
  - Re: [PATCH v5 3/8] util: rename qemu_open() to qemu_open_old(), Markus Armbruster, 2020/09/03
- [PATCH v5 4/8] util: refactor qemu_open_old to split off variadic args handling, Daniel P . Berrangé, 2020/09/02
  - Re: [PATCH v5 4/8] util: refactor qemu_open_old to split off variadic args handling, Markus Armbruster, 2020/09/03
- [PATCH v5 5/8] util: add Error object for qemu_open_internal error reporting, Daniel P . Berrangé, 2020/09/02
  - Re: [PATCH v5 5/8] util: add Error object for qemu_open_internal error reporting, Markus Armbruster, 2020/09/03
    - Re: [PATCH v5 5/8] util: add Error object for qemu_open_internal error reporting, Daniel P . Berrangé, 2020/09/03
- [PATCH v5 6/8] util: introduce qemu_open and qemu_create with error reporting, Daniel P . Berrangé, 2020/09/02
- [PATCH v5 7/8] util: give a specific error message when O_DIRECT doesn't work, Daniel P . Berrangé, 2020/09/02
- [PATCH v5 8/8] block/file: switch to use qemu_open/qemu_create for improved errors, Daniel P . Berrangé, 2020/09/02

Prev by Date: Re: [PATCH v5 1/8] monitor: simplify functions for getting a dup'd fdset entry
Next by Date: Re: [PATCH v5 3/8] util: rename qemu_open() to qemu_open_old()
Previous by thread: [PATCH v5 2/8] util: split off a helper for dealing with O_CLOEXEC flag
Next by thread: [PATCH v5 3/8] util: rename qemu_open() to qemu_open_old()
Index(es):
- Date
- Thread