Re: [PATCH v5 19/36] qapi/events.py: add type hint annotations

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 19/36] qapi/events.py: add type hint annotations

From:	Markus Armbruster
Subject:	Re: [PATCH v5 19/36] qapi/events.py: add type hint annotations
Date:	Fri, 09 Oct 2020 09:21:50 +0200
User-agent:	Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

John Snow <jsnow@redhat.com> writes:

[...]
> I just find it difficult to predict what reviewers will want.

Capricious bunch, those reviewers.

[...]

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v5 18/36] qapi: establish mypy type-checking baseline, (continued)
- [PATCH v5 18/36] qapi: establish mypy type-checking baseline, John Snow, 2020/10/05
  - Re: [PATCH v5 18/36] qapi: establish mypy type-checking baseline, Markus Armbruster, 2020/10/07
    - Re: [PATCH v5 18/36] qapi: establish mypy type-checking baseline, John Snow, 2020/10/07
    - Re: [PATCH v5 18/36] qapi: establish mypy type-checking baseline, Markus Armbruster, 2020/10/08
- [PATCH v5 19/36] qapi/events.py: add type hint annotations, John Snow, 2020/10/05
  - Re: [PATCH v5 19/36] qapi/events.py: add type hint annotations, Markus Armbruster, 2020/10/07
    - Re: [PATCH v5 19/36] qapi/events.py: add type hint annotations, Markus Armbruster, 2020/10/07
    - Re: [PATCH v5 19/36] qapi/events.py: add type hint annotations, John Snow, 2020/10/07
    - Re: [PATCH v5 19/36] qapi/events.py: add type hint annotations, Markus Armbruster, 2020/10/08
    - Re: [PATCH v5 19/36] qapi/events.py: add type hint annotations, John Snow, 2020/10/08
    - Re: [PATCH v5 19/36] qapi/events.py: add type hint annotations, Markus Armbruster <=
    - Re: [PATCH v5 19/36] qapi/events.py: add type hint annotations, John Snow, 2020/10/07
    - Re: [PATCH v5 19/36] qapi/events.py: add type hint annotations, Markus Armbruster, 2020/10/08
    - Re: [PATCH v5 19/36] qapi/events.py: add type hint annotations, John Snow, 2020/10/08
- [PATCH v5 20/36] qapi/events.py: Move comments into docstrings, John Snow, 2020/10/05
- [PATCH v5 22/36] qapi/commands.py: add type hint annotations, John Snow, 2020/10/05
- [PATCH v5 21/36] qapi/commands.py: Don't re-bind to variable of different type, John Snow, 2020/10/05
  - Re: [PATCH v5 21/36] qapi/commands.py: Don't re-bind to variable of different type, Markus Armbruster, 2020/10/07
- [PATCH v5 23/36] qapi/commands.py: enable checking with mypy, John Snow, 2020/10/05
  - Re: [PATCH v5 23/36] qapi/commands.py: enable checking with mypy, Markus Armbruster, 2020/10/07
    - Re: [PATCH v5 23/36] qapi/commands.py: enable checking with mypy, John Snow, 2020/10/07

Prev by Date: Re: does make check now require TCG? Or is it a parallelism issue?
Next by Date: Re: [PATCH v5 34/36] qapi/visit.py: assert tag_member contains a QAPISchemaEnumType
Previous by thread: Re: [PATCH v5 19/36] qapi/events.py: add type hint annotations
Next by thread: Re: [PATCH v5 19/36] qapi/events.py: add type hint annotations
Index(es):
- Date
- Thread