Re: [PATCH v4 4/7] nbd: Update qapi to support exporting multiple bitmaps

[Vladimir Sementsov-Ogievskiy]

10.10.2020 00:55, Eric Blake wrote:
> Since 'nbd-server-add' is deprecated, and 'block-export-add' is new to
> 5.2, we can still tweak the interface.  Allowing 'bitmaps':['str'] is
> nicer than 'bitmap':'str'.  This wires up the qapi and qemu-nbd
> changes to permit passing multiple bitmaps as distinct metadata
> contexts that the NBD client may request, but the actual support for
> more than one will require a further patch to the server.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---

[..]

>               break;
>           case 'B':
> -            bitmap = optarg;
> +            tmp = g_new(strList, 1);
> +            tmp->value = g_strdup(optarg);
> +            tmp->next = bitmaps;
> +            bitmaps = tmp;

If publish QAPI_LIST_ADD, defined in block.c, it would look like:

    QAPI_LIST_ADD(bitmaps, g_strdup(optarg));

anyway:
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

--
Best regards,
Vladimir