[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 08/11] sockets: Fix socket_sockaddr_to_address_unix() for
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH v2 08/11] sockets: Fix socket_sockaddr_to_address_unix() for abstract sockets |
|
Date: |
Mon, 2 Nov 2020 08:04:09 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 11/2/20 3:44 AM, Markus Armbruster wrote:
> Commit 776b97d360 "qemu-sockets: add abstract UNIX domain socket
> support" neglected to update socket_sockaddr_to_address_unix(). The
> function returns a non-abstract socket address for abstract
> sockets (wrong) with a null @path (also wrong; a non-optional QAPI str
> member must never be null).
>
> The null @path is due to confused code going back all the way to
> commit 17c55decec "sockets: add helpers for creating SocketAddress
> from a socket".
>
> Add the required special case, and simplify the confused code.
>
> Fixes: 776b97d3605ed0fc94443048fdf988c7725e38a9
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> util/qemu-sockets.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH v2 00/11] sockets: Attempt to drain the abstract socket swamp, Markus Armbruster, 2020/11/02
- [PATCH v2 02/11] test-util-sockets: Correct to set has_abstract, has_tight, Markus Armbruster, 2020/11/02
- [PATCH v2 06/11] test-util-sockets: Test the complete abstract socket matrix, Markus Armbruster, 2020/11/02
- [PATCH v2 01/11] test-util-sockets: Plug file descriptor leak, Markus Armbruster, 2020/11/02
- [PATCH v2 08/11] sockets: Fix socket_sockaddr_to_address_unix() for abstract sockets, Markus Armbruster, 2020/11/02
- Re: [PATCH v2 08/11] sockets: Fix socket_sockaddr_to_address_unix() for abstract sockets,
Eric Blake <=
- [PATCH v2 03/11] test-util-sockets: Clean up SocketAddress construction, Markus Armbruster, 2020/11/02
- [PATCH v2 10/11] sockets: Bypass "replace empty @path" for abstract unix sockets, Markus Armbruster, 2020/11/02
- [PATCH v2 04/11] test-util-sockets: Factor out test_socket_unix_abstract_one(), Markus Armbruster, 2020/11/02
- [PATCH v2 07/11] sockets: Fix default of UnixSocketAddress member @tight, Markus Armbruster, 2020/11/02
- [PATCH v2 05/11] test-util-sockets: Synchronize properly, don't sleep(1), Markus Armbruster, 2020/11/02
- [PATCH v2 09/11] char-socket: Fix qemu_chr_socket_address() for abstract sockets, Markus Armbruster, 2020/11/02