|
| From: | Philippe Mathieu-Daudé |
| Subject: | Re: [PATCH 2/4] gitlab: force enable docs build in Fedora, Ubuntu, Debian |
| Date: | Mon, 2 Nov 2020 15:50:39 +0100 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 11/2/20 2:09 PM, Daniel P. Berrangé wrote: > Meson runs a test to see if Sphinx works, and automatically disables it > on error. This can lead to the CI jobs skipping docs build without > maintainers noticing the problem. Use --enable-docs to force a fatal > error if Sphinx doesn't work on the jobs where we expect it to be OK. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > .gitlab-ci.yml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Shouldn't this patch go first in your series? Inverting 1<->2. Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
| [Prev in Thread] | Current Thread | [Next in Thread] |