Re: [PATCH v9 2/8] fw_cfg: Write the extra roots into the fw_cfg

[Laszlo Ersek]

+Phil, +Gerd

On 11/04/20 20:54, Laszlo Ersek wrote:
> +Marcel
> 
> On 11/03/20 13:01, Jiahui Cen wrote:
>> From: Yubo Miao <miaoyubo@huawei.com>
>>
>> Write the extra roots into the fw_cfg, therefore the uefi could
>> get the extra roots. Only if the uefi knows there are extra roots,
>> the config space of devices behind the root could be obtained.
>>
>> Signed-off-by: Yubo Miao <miaoyubo@huawei.com>
>> Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
>> ---
>>  hw/arm/virt.c              |  8 ++++++++
>>  hw/i386/pc.c               | 18 ++----------------
>>  hw/nvram/fw_cfg.c          | 20 ++++++++++++++++++++
>>  include/hw/nvram/fw_cfg.h  |  2 ++
>>  include/hw/pci/pcie_host.h |  4 ++++
>>  5 files changed, 36 insertions(+), 16 deletions(-)

I realize I never reacted to this patch before (and we're at v9), so you
might not welcome my feedback at this point.

The explanation why I've only reacted now is the following: there's an
agreement between Phil and myself that Phil handles fw_cfg reviews
primarily, and I review only (or almost only) Phil's patches for fw_cfg.
Furthermore, all versions of this particular patch, as far as I can see,
CC'd me but not Phil. So Phil never knew to look, and I never checked
(this being an fw_cfg patch, per subject line) beyond the author being
Phil or not.

The solution is of course to use the get_maintainer.pl script for
determining reviewers, and adding them with "Cc:" tags to the commit
message. (You also missed Marcel at the least; see my previous
response.) git-send-email is supposed to adhere to those "Cc:" tags.

The reason I've looked now is... I guess I was too tired to remember our
agreement with Phil.

Thanks
Laszlo