Re: [PATCH] replay: remove some dead code

[Philippe Mathieu-Daudé]

On 11/5/20 7:10 AM, Pavel Dovgalyuk wrote:
> This patch removes dead code in replay_continue_stop() function.
> 
> Signed-off-by: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>
> Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>

This is actually Coverity (CID 1433220).

Fixes: cda382594b7 ("gdbstub: add reverse continue support in replay mode")

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Thanks for the fix!

> ---
>  replay/replay-debugging.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/replay/replay-debugging.c b/replay/replay-debugging.c
> index ee9e86daa9..1d6a968406 100644
> --- a/replay/replay-debugging.c
> +++ b/replay/replay-debugging.c
> @@ -278,7 +278,6 @@ static void replay_continue_stop(void *opaque)
>              replay_continue_end();
>          }
>          replay_last_snapshot = replay_get_current_icount();
> -        return;
>      } else {
>          /* Seek to the very first step */
>          replay_seek(0, replay_stop_vm_debug, &err);
> @@ -286,9 +285,7 @@ static void replay_continue_stop(void *opaque)
>              error_free(err);
>              replay_continue_end();
>          }
> -        return;
>      }
> -    replay_continue_end();
>  }
>  
>  bool replay_reverse_continue(void)
>