qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

nbd: bitmap_to_extents() calls nbd_extent_array_add() without checking r


From: Peter Maydell
Subject: nbd: bitmap_to_extents() calls nbd_extent_array_add() without checking return value: coverity false positive?
Date: Fri, 6 Nov 2020 17:22:13 +0000

Hi; Coverity's "you usually check the return value of this function
but you didn't do that here" heuristic has fired on the code in
nbd/server.c:bitmap_to_extents() -- the function nbd_extent_array_add()
is called five times in server.c, and the return value is checked
in four of those, but not in the final call at the end of
bitmap_to_extents(). (CID 1436125.)

Is this a false positive, or should the caller be handling an
error here ?

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]