Re: [PATCH v4 2/4] Jobs based on custom runners: build environment docs and playbook

[Cleber Rosa]

On Tue, Oct 20, 2020 at 08:18:54AM +0200, Erik Skultety wrote:
> On Mon, Oct 19, 2020 at 04:25:31PM -0400, Cleber Rosa wrote:
> > On Mon, Oct 19, 2020 at 12:27:41PM +0200, Erik Skultety wrote:
> > > ...
> > > 
> > > > diff --git a/scripts/ci/setup/inventory b/scripts/ci/setup/inventory
> > > > new file mode 100644
> > > > index 0000000000..8bb7ba6b33
> > > > --- /dev/null
> > > > +++ b/scripts/ci/setup/inventory
> > > > @@ -0,0 +1,2 @@
> > > > +[local]
> > > 
> > > Nit pick, is a group for localhost actually needed?
> > >
> > 
> > You're right, it's not needed... I just thought it gave the
> > "localhost" entry some "shelter" and "context". :)
> > 
> > And, I think a mostly "ini-like" file without a section triggers an OCD
> > reaction in me.  I can remove it if it does something similar to you! :)
> > 
> > Thanks!
> > - Cleber.
> 
> I understand, but even though it may be an ini-like config, "sections" have a
> very distinct meaning in Ansible and that is grouping, so unless there are
> hosts to group, I'd keep the inventory in a form of a simple list of 
> individual
> hosts.
>

Fair enough.  Changing it for v5.

Thanks!
- Cleber.

> Regards,
> Erik

signature.asc
Description: PGP signature