[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2] multifd/tls: fix memoryleak of the QIOChannelSocket object wh
|
From: |
Chuan Zheng |
|
Subject: |
[PATCH v2] multifd/tls: fix memoryleak of the QIOChannelSocket object when cancelling migration |
|
Date: |
Wed, 11 Nov 2020 22:26:03 +0800 |
When creating new tls client, the tioc->master will be referenced which results
in socket
leaking after multifd_save_cleanup if we cancel migration.
Fix it by do object_unref() after tls client creation.
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
---
migration/multifd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration/multifd.c b/migration/multifd.c
index 68b171f..6992761 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -752,6 +752,7 @@ static void multifd_tls_channel_connect(MultiFDSendParams
*p,
return;
}
+ object_unref(OBJECT(ioc));
trace_multifd_tls_outgoing_handshake_start(ioc, tioc, hostname);
qio_channel_set_name(QIO_CHANNEL(tioc), "multifd-tls-outgoing");
qio_channel_tls_handshake(tioc,
--
1.8.3.1
- [PATCH v2] multifd/tls: fix memoryleak of the QIOChannelSocket object when cancelling migration,
Chuan Zheng <=