[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 25/53] qdev: Make qdev_class_add_property() more flexible
|
From: |
Eduardo Habkost |
|
Subject: |
[PATCH v3 25/53] qdev: Make qdev_class_add_property() more flexible |
|
Date: |
Thu, 12 Nov 2020 16:43:22 -0500 |
Support Property.set_default and PropertyInfo.description even if
PropertyInfo.create is set.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Changes v1 -> v2:
* Patch redone after changes in the previous patches in the
series
---
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org
---
hw/core/qdev-properties.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index 3bb05e7d0d..fcda0c8f4b 100644
--- a/hw/core/qdev-properties.c
+++ b/hw/core/qdev-properties.c
@@ -863,24 +863,25 @@ static void qdev_class_add_property(DeviceClass *klass,
const char *name,
Property *prop)
{
ObjectClass *oc = OBJECT_CLASS(klass);
+ ObjectProperty *op;
if (prop->info->create) {
- prop->info->create(oc, name, prop);
+ op = prop->info->create(oc, name, prop);
} else {
- ObjectProperty *op;
-
op = object_class_property_add(oc,
name, prop->info->name,
field_prop_getter(prop->info),
field_prop_setter(prop->info),
prop->info->release,
prop);
- if (prop->set_default) {
- prop->info->set_default_value(op, prop);
- }
}
- object_class_property_set_description(oc, name,
- prop->info->description);
+ if (prop->set_default) {
+ prop->info->set_default_value(op, prop);
+ }
+ if (prop->info->description) {
+ object_class_property_set_description(oc, name,
+ prop->info->description);
+ }
}
/**
--
2.28.0
- [PATCH v3 17/53] sparc: Use DEFINE_PROP for nwindows property, (continued)
- [PATCH v3 17/53] sparc: Use DEFINE_PROP for nwindows property, Eduardo Habkost, 2020/11/12
- [PATCH v3 16/53] qdev: Reuse DEFINE_PROP in all DEFINE_PROP_* macros, Eduardo Habkost, 2020/11/12
- [PATCH v3 15/53] qdev: Move softmmu properties to qdev-properties-system.h, Eduardo Habkost, 2020/11/12
- [PATCH v3 18/53] qdev: Get just property name at error_set_from_qdev_prop_error(), Eduardo Habkost, 2020/11/12
- [PATCH v3 19/53] qdev: Avoid using prop->name unnecessarily, Eduardo Habkost, 2020/11/12
- [PATCH v3 20/53] qdev: Add name parameter to qdev_class_add_property(), Eduardo Habkost, 2020/11/12
- [PATCH v3 21/53] qdev: Add name argument to PropertyInfo.create method, Eduardo Habkost, 2020/11/12
- [PATCH v3 22/53] qdev: Wrap getters and setters in separate helpers, Eduardo Habkost, 2020/11/12
- [PATCH v3 23/53] qdev: Move dev->realized check to qdev_property_set(), Eduardo Habkost, 2020/11/12
- [PATCH v3 24/53] qdev: Make PropertyInfo.create return ObjectProperty*, Eduardo Habkost, 2020/11/12
- [PATCH v3 25/53] qdev: Make qdev_class_add_property() more flexible,
Eduardo Habkost <=
- [PATCH v3 26/53] qdev: Separate generic and device-specific property registration, Eduardo Habkost, 2020/11/12
- [PATCH v3 27/53] qdev: Rename qdev_propinfo_* to field_prop_*, Eduardo Habkost, 2020/11/12
- [PATCH v3 28/53] qdev: Move qdev_prop_tpm declaration to tpm_prop.h, Eduardo Habkost, 2020/11/12
- [PATCH v3 29/53] qdev: Rename qdev_prop_* to prop_info_*, Eduardo Habkost, 2020/11/12
- [PATCH v3 30/53] qdev: Rename qdev_get_prop_ptr() to object_field_prop_ptr(), Eduardo Habkost, 2020/11/12
- [PATCH v3 31/53] qdev: Avoid unnecessary DeviceState* variable at set_prop_arraylen(), Eduardo Habkost, 2020/11/12
- [PATCH v3 32/53] tests: Add unit test for qdev array properties, Eduardo Habkost, 2020/11/12
- [PATCH v3 33/53] qom: Add allow_set callback to ObjectProperty, Eduardo Habkost, 2020/11/12
- [PATCH v3 34/53] qdev: Make qdev_prop_allow_set() a ObjectProperty.allow_set callback, Eduardo Habkost, 2020/11/12
- [PATCH v3 36/53] qdev: Don't set .name_template for array elements, Eduardo Habkost, 2020/11/12