[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 05/10] ui: Improve a client_migrate_info error message
|
From: |
Markus Armbruster |
|
Subject: |
[PATCH 05/10] ui: Improve a client_migrate_info error message |
|
Date: |
Fri, 13 Nov 2020 09:26:21 +0100 |
client_migrate_info reports spice_server_migrate_connect() failure as
"An undefined error has occurred". Improve to "Could not set up
display for migration".
QERR_UNDEFINED_ERROR is now unused. Drop.
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
include/qapi/qmp/qerror.h | 3 ---
monitor/misc.c | 2 +-
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h
index d8267129bc..596fce0c54 100644
--- a/include/qapi/qmp/qerror.h
+++ b/include/qapi/qmp/qerror.h
@@ -65,9 +65,6 @@
#define QERR_REPLAY_NOT_SUPPORTED \
"Record/replay feature is not supported for '%s'"
-#define QERR_UNDEFINED_ERROR \
- "An undefined error has occurred"
-
#define QERR_UNSUPPORTED \
"this feature or command is not currently supported"
diff --git a/monitor/misc.c b/monitor/misc.c
index 9aa2505cfa..f0d3d41753 100644
--- a/monitor/misc.c
+++ b/monitor/misc.c
@@ -441,7 +441,7 @@ void qmp_client_migrate_info(const char *protocol, const
char *hostname,
has_port ? port : -1,
has_tls_port ? tls_port : -1,
cert_subject)) {
- error_setg(errp, QERR_UNDEFINED_ERROR);
+ error_setg(errp, "Could not set up display for migration");
return;
}
return;
--
2.26.2
- [PATCH 00/10] Chipping away at qerror.h, Markus Armbruster, 2020/11/13
- [PATCH 01/10] qerror: Drop unused QERR_ macros, Markus Armbruster, 2020/11/13
- [PATCH 03/10] block: Improve some block-commit, block-stream error messages, Markus Armbruster, 2020/11/13
- [PATCH 02/10] qerror: Eliminate QERR_ macros used in just one place, Markus Armbruster, 2020/11/13
- [PATCH 09/10] qom: Improve {qom, device}-list-properties error messages, Markus Armbruster, 2020/11/13
- [PATCH 10/10] Tweak a few "Parameter 'NAME' expects THING" error message, Markus Armbruster, 2020/11/13
- [PATCH 08/10] qga: Tweak a guest-shutdown error message, Markus Armbruster, 2020/11/13
- [PATCH 05/10] ui: Improve a client_migrate_info error message,
Markus Armbruster <=
- [PATCH 06/10] ui: Tweak a client_migrate_info error message, Markus Armbruster, 2020/11/13
- [PATCH 07/10] qga: Replace an unreachable error by abort(), Markus Armbruster, 2020/11/13
- [PATCH 04/10] ui: Improve some set_passwd, expire_password error messages, Markus Armbruster, 2020/11/13