[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] Fix build with 64 bits time_t
|
From: |
Fabrice Fontaine |
|
Subject: |
Re: [PATCH v3] Fix build with 64 bits time_t |
|
Date: |
Fri, 27 Nov 2020 23:24:03 +0100 |
Hi,
Le ven. 27 nov. 2020 à 08:18, Gerd Hoffmann <kraxel@redhat.com> a écrit :
>
> Hi,
>
> > Changes v2 -> v3 (after review of Gerd Hoffmann):
> > - Replace include on <linux/input.h> by
> > "standard-headers/linux/input.h" to try to fix build on rhel-7
>
> Now it complains about ioctl() not being declared.
>
> /me suggests to create a fork @ gitlab.com and push your branch there,
> that'll run it through CI and we have a centos7 build job there which
> should catch this ...
I fixed the issue by including sys/ioctl.h.
However, I have a test failure due to a timeout on
check-system-centos:
https://gitlab.com/ffontaine/qemu/-/jobs/877810804
It does seem to be related to my patch. Should I send a v4 on the mailing list?
>
> take care,
> Gerd
>
Best Regards,
Fabrice