[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 8/9] vnc: add support for extended desktop resize
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [PATCH 8/9] vnc: add support for extended desktop resize |
|
Date: |
Fri, 4 Dec 2020 07:37:50 +0100 |
Hi,
> > + case VNC_ENCODING_DESKTOP_RESIZE_EXT:
> > + vs->features |= VNC_FEATURE_RESIZE_EXT_MASK;
>
> IIUC, we shouldn't set this flag unless all current displays adapters
> associated with the VNC server support the "ui_info" callbacks,
> otherwise the client will think it can send resize requests
> but they'll never be honoured.
Well, that can happen anyway as honoring the request is in the hands of
the guest and not something qemu can guarantee. So vnc clients must be
able to deal with that no matter what. The spec even explicitly states
that rejecting all resize requests from the client is perfectly valid
behavior for a server.
For tigervnc it seems to make no difference whenever the server supports
extended desktop resize or not.
I doubt making this conditional buys us anything ...
take care,
Gerd
- [PATCH 7/9] vnc: force initial resize message, (continued)
- [PATCH 7/9] vnc: force initial resize message, Gerd Hoffmann, 2020/12/03
- [PATCH 5/9] vnc: add pseudo encodings, Gerd Hoffmann, 2020/12/03
- [PATCH 3/9] vnc: use enum for features, Gerd Hoffmann, 2020/12/03
- [PATCH 8/9] vnc: add support for extended desktop resize, Gerd Hoffmann, 2020/12/03
- [PATCH 6/9] vnc: add alpha cursor support, Gerd Hoffmann, 2020/12/03