|
| From: | Alberto Garcia |
| Subject: | Re: [PATCH v4 2/4] block: add bdrv_co_delete_file_noerr |
| Date: | Wed, 09 Dec 2020 18:34:17 +0100 |
| User-agent: | Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Wed 09 Dec 2020 05:44:39 PM CET, Maxim Levitsky wrote:
> +void coroutine_fn bdrv_co_delete_file_noerr(BlockDriverState *bs)
> +{
> + Error *local_err = NULL;
> +
> + if (!bs) {
> + return;
> + }
> +
> + int ret = bdrv_co_delete_file(bs, &local_err);
^^^
According to the QEMU coding style we should not have declarations in
the middle of a block.
The patch looks otherwise fine.
Reviewed-by: Alberto Garcia <berto@igalia.com>
Berto
| [Prev in Thread] | Current Thread | [Next in Thread] |