Re: [PATCH v2 08/10] softmmu/physmem: Extend ram_block_discard_(require|disable) by two discard types

[Pankaj Gupta]

> [...]
>
> >> +/* Disable only uncoordinated disards. */
> > s/disards/discards
>
> Thanks!
>
> [...]
>
> >>
> >>  bool ram_block_discard_is_required(void)
> >>  {
> >> -    return qatomic_read(&ram_block_discard_requirers);
> >> +    return qatomic_read(&ram_block_discard_requirers) ||
> >> +           qatomic_read(&ram_block_coordinated_discard_requirers);
> >>  }
> >
> > How to differentiate if we have both un-coordinated & coordinated
> > cases together?
>
> Checking for both is sufficient for current users - which only care if
> any type of discard is required to work. Thanks!
O.k. Looks good to me.

Reviewed-by: Pankaj Gupta <pankaj.gupta@cloud.ionos.com>