[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] monitor/qmp-cmds.c: Don't include ui/vnc.h
From: |
Peter Maydell |
Subject: |
[PATCH] monitor/qmp-cmds.c: Don't include ui/vnc.h |
Date: |
Mon, 4 Jan 2021 16:12:00 +0000 |
The qmp-cmds.c file currently includes ui/vnc.h, which (being located
in the ui/ directory rather than include) is really supposed to be
for use only by the ui subsystem. In fact the function prototypes we
need (vnc_display_password(), etc) are all declared in
include/ui/console.h, so we can switch to including that instead.
(ui/vnc.h includes include/ui/console.h, so this change strictly
reduces the quantity of headers qmp-cmds.c pulls in.)
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
Spotted while trying to reduce the number of source files that
indirectly include <gnutls.h>...
---
monitor/qmp-cmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/monitor/qmp-cmds.c b/monitor/qmp-cmds.c
index 34f7e75b7bf..c95e5001d72 100644
--- a/monitor/qmp-cmds.c
+++ b/monitor/qmp-cmds.c
@@ -23,7 +23,7 @@
#include "qemu/uuid.h"
#include "chardev/char.h"
#include "ui/qemu-spice.h"
-#include "ui/vnc.h"
+#include "ui/console.h"
#include "sysemu/kvm.h"
#include "sysemu/runstate.h"
#include "sysemu/runstate-action.h"
--
2.20.1
- [PATCH] monitor/qmp-cmds.c: Don't include ui/vnc.h,
Peter Maydell <=