[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 17/23] paaudio: comment bugs in functions qpa_init_*
From: |
Volker Rümelin |
Subject: |
[PATCH 17/23] paaudio: comment bugs in functions qpa_init_* |
Date: |
Sun, 10 Jan 2021 11:02:33 +0100 |
The audio buffer size in audio/paaudio.c is typically larger
than expected. Just comment the bugs in qpa_init_in() and
qpa_init_out() for now. Fixing these bugs may break glitch free
audio playback with fine tuned user audio settings.
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
---
audio/paaudio.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/audio/paaudio.c b/audio/paaudio.c
index 86038f3e13..ff3dd01c96 100644
--- a/audio/paaudio.c
+++ b/audio/paaudio.c
@@ -538,6 +538,10 @@ static int qpa_init_out(HWVoiceOut *hw, struct audsettings
*as,
}
audio_pcm_init_info (&hw->info, &obt_as);
+ /*
+ * This is wrong. hw->samples counts in frames. hw->samples will be
+ * number of channels times larger than expected.
+ */
hw->samples = audio_buffer_samples(
qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, 46440);
@@ -585,6 +589,10 @@ static int qpa_init_in(HWVoiceIn *hw, struct audsettings
*as, void *drv_opaque)
}
audio_pcm_init_info (&hw->info, &obt_as);
+ /*
+ * This is wrong. hw->samples counts in frames. hw->samples will be
+ * number of channels times larger than expected.
+ */
hw->samples = audio_buffer_samples(
qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, 46440);
--
2.26.2
- [PATCH 08/23] audio: split pcm_ops function get_buffer_in, (continued)
- [PATCH 08/23] audio: split pcm_ops function get_buffer_in, Volker Rümelin, 2021/01/10
- [PATCH 09/23] sdlaudio: add recording functions, Volker Rümelin, 2021/01/10
- [PATCH 11/23] sdlaudio: enable (in|out).mixing-engine=off, Volker Rümelin, 2021/01/10
- [PATCH 13/23] paaudio: avoid to clip samples multiple times, Volker Rümelin, 2021/01/10
- [PATCH 14/23] paaudio: wait for PA_STREAM_READY in qpa_write(), Volker Rümelin, 2021/01/10
- [PATCH 15/23] paaudio: wait until the playback stream is ready, Volker Rümelin, 2021/01/10
- [PATCH 12/23] audio: remove remaining unused plive code, Volker Rümelin, 2021/01/10
- [PATCH 16/23] paaudio: remove unneeded code, Volker Rümelin, 2021/01/10
- [PATCH 18/23] paaudio: limit minreq to 75% of audio timer_rate, Volker Rümelin, 2021/01/10
- [PATCH 20/23] dsoundaudio: replace GetForegroundWindow(), Volker Rümelin, 2021/01/10
- [PATCH 17/23] paaudio: comment bugs in functions qpa_init_*,
Volker Rümelin <=
- [PATCH 19/23] paaudio: send recorded data in smaller chunks, Volker Rümelin, 2021/01/10
- [PATCH 21/23] dsoundaudio: rename dsound_open(), Volker Rümelin, 2021/01/10
- [PATCH 22/23] dsoundaudio: enable f32 audio sample format, Volker Rümelin, 2021/01/10
- [PATCH 23/23] dsoundaudio: fix log message, Volker Rümelin, 2021/01/10
- Re: [PATCH 00/23] next round of audio patches, no-reply, 2021/01/10
- Re: [PATCH 00/23] next round of audio patches, Gerd Hoffmann, 2021/01/14