[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 05/35] Hexagon (disas) disassembler
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v6 05/35] Hexagon (disas) disassembler |
Date: |
Mon, 11 Jan 2021 23:20:27 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
+Thomas/Daniel/Peter.
On 1/11/21 10:14 PM, Taylor Simpson wrote:
>> -----Original Message-----
>> From: Qemu-devel <qemu-devel-
>> bounces+tsimpson=quicinc.com@nongnu.org> On Behalf Of Philippe
>> Mathieu-Daudé
>> Sent: Saturday, January 9, 2021 3:38 PM
>> To: Taylor Simpson <tsimpson@quicinc.com>; qemu-devel@nongnu.org
>> Cc: ale@rev.ng; Brian Cain <bcain@quicinc.com>;
>> richard.henderson@linaro.org; laurent@vivier.eu
>> Subject: Re: [PATCH v6 05/35] Hexagon (disas) disassembler
>>
>> Hi Taylor,
>>
>> On 1/8/21 5:28 AM, Taylor Simpson wrote:
>>> +/*
>>> + * Copyright(c) 2019-2020 Qualcomm Innovation Center, Inc. All Rights
>> Reserved.
>>
>> 2019-2021 :)
>>
>>> + *
>>> + * This program is free software; you can redistribute it and/or modify
>>> + * it under the terms of the GNU General Public License as published by
>>> + * the Free Software Foundation; either version 2 of the License, or
>>> + * (at your option) any later version.
>>> + *
>>> + * This program is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>>> + * GNU General Public License for more details.
>>> + *
>>> + * You should have received a copy of the GNU General Public License
>>> + * along with this program; if not, see <http://www.gnu.org/licenses/>.
>>
>> If possible please also include the SPDX identifier (or simply it):
>>
>> SPDX-License-Identifier: GPL-2.0-or-later
>
> I'll confirm with our legal department. Which is preferred - the identifier
> alone or the text and the identifier?
Obviously IANAL, but my understanding from explanations from Thomas and
Daniel is -- if one day QEMU switches to using SPDX -- when both are
provided, it is very hard to remove a text license (which often is
copy/pasted with mistakes). So the identifier alone is better (assuming
your legal department confirms it has the same value).
Now if you ask if there is any plan QEMU switch to SPDX, I'd say this
is a gray zone. Peter expressively said he prefers a full switch or
nothing. We don't have the resources for it. Meanwhile some companies
prefer their employees to send new contributions with SPDX as it eases
their compliance audit tools.
I guess Thomas spend 1 week on this topic. TBH I spent more than 2 weeks
and barely added the SPDX tag to a bit more than 30% of the codebase
then had to give up because my time was over (this was when I understood
I couldn't remove the text and had to redo the work).
Not sure how this can be coordinated. As long as there is no strong
corporate interest, this might stay in this gray zone...
Regards,
Phil.
- [PATCH v6 09/35] Hexagon (target/hexagon) architecture types, (continued)
- [PATCH v6 09/35] Hexagon (target/hexagon) architecture types, Taylor Simpson, 2021/01/07
- [PATCH v6 12/35] Hexagon (target/hexagon) instruction attributes, Taylor Simpson, 2021/01/07
- [PATCH v6 06/35] Hexagon (target/hexagon) register names, Taylor Simpson, 2021/01/07
- [PATCH v6 07/35] Hexagon (target/hexagon) scalar core helpers, Taylor Simpson, 2021/01/07
- [PATCH v6 17/35] Hexagon (target/hexagon/fma_emu.[ch]) utility functions, Taylor Simpson, 2021/01/07
- [PATCH v6 21/35] Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode tree, Taylor Simpson, 2021/01/07
- [PATCH v6 04/35] Hexagon (target/hexagon) scalar core definition, Taylor Simpson, 2021/01/07
- [PATCH v6 05/35] Hexagon (disas) disassembler, Taylor Simpson, 2021/01/07
[PATCH v6 26/35] Hexagon (target/hexagon) TCG generation, Taylor Simpson, 2021/01/07
[PATCH v6 10/35] Hexagon (target/hexagon) instruction and packet types, Taylor Simpson, 2021/01/07
[PATCH v6 30/35] Hexagon (linux-user/hexagon) Linux user emulation, Taylor Simpson, 2021/01/07
[PATCH v6 11/35] Hexagon (target/hexagon) register fields, Taylor Simpson, 2021/01/07
[PATCH v6 08/35] Hexagon (target/hexagon) GDB Stub, Taylor Simpson, 2021/01/07
[PATCH v6 14/35] Hexagon (target/hexagon) instruction printing, Taylor Simpson, 2021/01/07
[PATCH v6 13/35] Hexagon (target/hexagon) instruction/packet decode, Taylor Simpson, 2021/01/07