[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns |
Date: |
Wed, 13 Jan 2021 09:48:04 +0000 |
On Tue, Jan 12, 2021 at 09:44:03PM +0100, BALATON Zoltan wrote:
> On Tue, 12 Jan 2021, Stefan Hajnoczi wrote:
> > It is possible to repeat the --trace option to specify multiple
> > patterns. This may be preferrable to users who do not want to create a
> > file with a list of patterns.
> >
> > Suggested-by: BALATON Zoltan <balaton@eik.bme.hu>
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > docs/devel/tracing.rst | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/docs/devel/tracing.rst b/docs/devel/tracing.rst
> > index 4ebf8e38ea..8777c19d14 100644
> > --- a/docs/devel/tracing.rst
> > +++ b/docs/devel/tracing.rst
> > @@ -22,10 +22,15 @@ events::
> > This output comes from the "log" trace backend that is enabled by default
> > when
> > ``./configure --enable-trace-backends=BACKENDS`` was not explicitly
> > specified.
> >
> > -More than one trace event pattern can be specified by providing a file
> > -instead::
> > +Multiple patterns can be specified by repeating the ``--trace`` option::
> > +
> > + $ qemu --trace "kvm_*" --trace "virtio_*" ...
>
> QEMU options are single dash with double dash accepted for compatibility but
> help and other docs have single dash so these (and below) should be -trace.
> (Also a bit less typing for otherwise already way too long command lines.)
Is this documented somewhere?
I was under the impression that '-' is legacy syntax and '--' is the
preferred syntax. There are examples of '--' on the QEMU man page.
Let's reach agreement, document it, and then make the documentation
consistent.
Stefan
signature.asc
Description: PGP signature
- [PATCH 0/2] trace: documentation improvements, Stefan Hajnoczi, 2021/01/12
- [PATCH 1/2] trace: document how to specify multiple --trace patterns, Stefan Hajnoczi, 2021/01/12
- Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns, Philippe Mathieu-Daudé, 2021/01/12
- Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns, BALATON Zoltan, 2021/01/12
- Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns, John Snow, 2021/01/13
- Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns, Eric Blake, 2021/01/13
- Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns, John Snow, 2021/01/13
- Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns, BALATON Zoltan, 2021/01/13
- Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns, John Snow, 2021/01/13
- Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns, Stefan Hajnoczi, 2021/01/14
- Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns, BALATON Zoltan, 2021/01/14
- Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns, Stefan Hajnoczi, 2021/01/14
- Re: [PATCH 1/2] trace: document how to specify multiple --trace patterns, Eric Blake, 2021/01/19