[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 06/25] tests/docker: remove FEATURES env var from template
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 06/25] tests/docker: remove FEATURES env var from templates |
Date: |
Thu, 14 Jan 2021 15:01:38 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/14/21 2:02 PM, Daniel P. Berrangé wrote:
> In preparation for switching to auto-generated dockerfiles, remove the
> FEATURES env variable. The equivalent functionality can be achieved in
> most cases by just looking for existance of a binary.
>
> The cases which don't correspond to binaries are simply dropped because
> configure/meson will probe for any requested feature anyway.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> tests/docker/common.rc | 19 ++++++++++++++-----
> tests/docker/dockerfiles/debian10.docker | 2 --
> .../dockerfiles/fedora-win32-cross.docker | 1 -
> .../dockerfiles/fedora-win64-cross.docker | 1 -
> tests/docker/dockerfiles/fedora.docker | 1 -
> tests/docker/dockerfiles/ubuntu.docker | 1 -
> tests/docker/dockerfiles/ubuntu1804.docker | 1 -
> tests/docker/dockerfiles/ubuntu2004.docker | 1 -
> tests/docker/run | 3 ---
> tests/docker/test-clang | 2 +-
> tests/docker/test-debug | 2 +-
> tests/docker/test-mingw | 3 ++-
> tests/docker/test-misc | 2 +-
> tests/docker/test-tsan | 2 +-
> 14 files changed, 20 insertions(+), 21 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH v2 04/25] tests/docker: use explicit docker.io registry, (continued)
- [PATCH v2 04/25] tests/docker: use explicit docker.io registry, Daniel P . Berrangé, 2021/01/14
- [PATCH v2 02/25] tests/docker: don't use BUILDKIT in GitLab either, Daniel P . Berrangé, 2021/01/14
- [PATCH v2 05/25] tests/docker: remove travis container, Daniel P . Berrangé, 2021/01/14
- [PATCH v2 08/25] tests/docker: fix mistakes in centos package lists, Daniel P . Berrangé, 2021/01/14
- [PATCH v2 06/25] tests/docker: remove FEATURES env var from templates, Daniel P . Berrangé, 2021/01/14
- Re: [PATCH v2 06/25] tests/docker: remove FEATURES env var from templates,
Philippe Mathieu-Daudé <=
- [PATCH v2 09/25] tests/docker: fix mistakes in fedora package list, Daniel P . Berrangé, 2021/01/14
- [PATCH v2 07/25] tests/docker: fix sorting in package lists, Daniel P . Berrangé, 2021/01/14
- [PATCH v2 10/25] tests/docker: fix mistakes in ubuntu package lists, Daniel P . Berrangé, 2021/01/14
- [PATCH v2 12/25] tests/docker: add script for automating container refresh, Daniel P . Berrangé, 2021/01/14
- [PATCH v2 11/25] tests/docker: remove mingw packages from Fedora, Daniel P . Berrangé, 2021/01/14