[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/6] hw/block/nvme: fix shutdown/reset logic
From: |
Keith Busch |
Subject: |
Re: [PATCH 1/6] hw/block/nvme: fix shutdown/reset logic |
Date: |
Thu, 14 Jan 2021 15:49:49 -0800 |
On Mon, Jan 11, 2021 at 01:32:18PM +0100, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> A shutdown is only about flushing stuff. It is the host that should
> delete any queues, so do not perform a reset here.
>
> Also, on shutdown, make sure that the PMR is flushed if in use.
>
> Fixes: 368f4e752cf9 ("hw/block/nvme: Process controller reset and shutdown
> differently")
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Yes, and exiting a controller shutdown state requires a controller
reset, so a functioning host shouldn't require the controller behave the
way it's currently done.
Reviewed-by: Keith Busch <kbusch@kernel.org>
- [PATCH 0/6] hw/block/nvme: zoned misc fixes, Klaus Jensen, 2021/01/11
- [PATCH 1/6] hw/block/nvme: fix shutdown/reset logic, Klaus Jensen, 2021/01/11
- Re: [PATCH 1/6] hw/block/nvme: fix shutdown/reset logic,
Keith Busch <=
- [PATCH 2/6] hw/block/nvme: merge implicitly/explicitly opened processing masks, Klaus Jensen, 2021/01/11
- [PATCH 3/6] hw/block/nvme: enum style fix, Klaus Jensen, 2021/01/11
- [PATCH 4/6] hw/block/nvme: zero out zones on reset, Klaus Jensen, 2021/01/11
- [PATCH 5/6] hw/block/nvme: add missing string representations for commands, Klaus Jensen, 2021/01/11
- [PATCH 6/6] hw/block/nvme: remove unnecessary check for append, Klaus Jensen, 2021/01/11
- Re: [PATCH 0/6] hw/block/nvme: zoned misc fixes, Dmitry Fomichev, 2021/01/17