[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 08/11] vnc: Fix a memleak in vnc_display_connect()
From: |
Gerd Hoffmann |
Subject: |
[PULL 08/11] vnc: Fix a memleak in vnc_display_connect() |
Date: |
Fri, 15 Jan 2021 11:24:21 +0100 |
From: Alex Chen <alex.chen@huawei.com>
Free the 'sioc' when the qio_channel_socket_connect_sync() fails.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Alex Chen <alex.chen@huawei.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20201126065702.35095-1-alex.chen@huawei.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
ui/vnc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ui/vnc.c b/ui/vnc.c
index a0bf750767a2..d4854d351bac 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3805,6 +3805,7 @@ static int vnc_display_connect(VncDisplay *vd,
sioc = qio_channel_socket_new();
qio_channel_set_name(QIO_CHANNEL(sioc), "vnc-reverse");
if (qio_channel_socket_connect_sync(sioc, saddr[0], errp) < 0) {
+ object_unref(OBJECT(sioc));
return -1;
}
vnc_connect(vd, sioc, false, false);
--
2.29.2
- [PULL 00/11] Ui 20210115 patches, Gerd Hoffmann, 2021/01/15
- [PULL 02/11] ui/gtk: rename variable window to widget, Gerd Hoffmann, 2021/01/15
- [PULL 01/11] ui/gtk: don't try to redefine SI prefixes, Gerd Hoffmann, 2021/01/15
- [PULL 03/11] ui/gtk: limit virtual console max update interval, Gerd Hoffmann, 2021/01/15
- [PULL 04/11] ui/gtk: expose gd_monitor_update_interval, Gerd Hoffmann, 2021/01/15
- [PULL 10/11] vnc: move initialization to framebuffer_update_request, Gerd Hoffmann, 2021/01/15
- [PULL 07/11] ui: add support for remote power control to VNC server, Gerd Hoffmann, 2021/01/15
- [PULL 08/11] vnc: Fix a memleak in vnc_display_connect(),
Gerd Hoffmann <=
- [PULL 05/11] ui/gtk: update monitor interval on egl displays, Gerd Hoffmann, 2021/01/15
- [PULL 11/11] vnc: add support for extended desktop resize, Gerd Hoffmann, 2021/01/15
- [PULL 06/11] vnc: fix unfinalized tlscreds for VncDisplay, Gerd Hoffmann, 2021/01/15
- [PULL 09/11] vnc: move check into vnc_cursor_define, Gerd Hoffmann, 2021/01/15
- Re: [PULL 00/11] Ui 20210115 patches, Peter Maydell, 2021/01/15