[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 16/30] paaudio: remove unneeded code
From: |
Gerd Hoffmann |
Subject: |
[PULL 16/30] paaudio: remove unneeded code |
Date: |
Fri, 15 Jan 2021 14:21:32 +0100 |
From: Volker RĂ¼melin <vr_qemu@t-online.de>
Commit baea032ec7 "audio/paaudio: fix ignored buffer_length setting"
added code to handle buffer_length defaults. This was unnecessary
because the audio_buffer_* functions in audio/audio.c already handle
this. Remove the unneeded code.
Signed-off-by: Volker RĂ¼melin <vr_qemu@t-online.de>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-16-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
audio/paaudio.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/audio/paaudio.c b/audio/paaudio.c
index 4a1ffda753d5..86038f3e1392 100644
--- a/audio/paaudio.c
+++ b/audio/paaudio.c
@@ -539,8 +539,7 @@ static int qpa_init_out(HWVoiceOut *hw, struct audsettings
*as,
audio_pcm_init_info (&hw->info, &obt_as);
hw->samples = audio_buffer_samples(
- qapi_AudiodevPaPerDirectionOptions_base(ppdo),
- &obt_as, ppdo->buffer_length);
+ qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, 46440);
return 0;
@@ -587,8 +586,7 @@ static int qpa_init_in(HWVoiceIn *hw, struct audsettings
*as, void *drv_opaque)
audio_pcm_init_info (&hw->info, &obt_as);
hw->samples = audio_buffer_samples(
- qapi_AudiodevPaPerDirectionOptions_base(ppdo),
- &obt_as, ppdo->buffer_length);
+ qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, 46440);
return 0;
@@ -738,10 +736,6 @@ static void qpa_volume_in(HWVoiceIn *hw, Volume *vol)
static int qpa_validate_per_direction_opts(Audiodev *dev,
AudiodevPaPerDirectionOptions *pdo)
{
- if (!pdo->has_buffer_length) {
- pdo->has_buffer_length = true;
- pdo->buffer_length = 46440;
- }
if (!pdo->has_latency) {
pdo->has_latency = true;
pdo->latency = 15000;
--
2.29.2
- [PULL 23/30] dsoundaudio: fix log message, (continued)
- [PULL 23/30] dsoundaudio: fix log message, Gerd Hoffmann, 2021/01/15
- [PULL 24/30] audio: Add braces for statements/fix braces' position, Gerd Hoffmann, 2021/01/15
- [PULL 13/30] paaudio: avoid to clip samples multiple times, Gerd Hoffmann, 2021/01/15
- [PULL 14/30] paaudio: wait for PA_STREAM_READY in qpa_write(), Gerd Hoffmann, 2021/01/15
- [PULL 25/30] audio: Add spaces around operator/delete redundant spaces, Gerd Hoffmann, 2021/01/15
- [PULL 29/30] audio: Suspect code indent for conditional statements, Gerd Hoffmann, 2021/01/15
- [PULL 17/30] paaudio: comment bugs in functions qpa_init_*, Gerd Hoffmann, 2021/01/15
- [PULL 19/30] paaudio: send recorded data in smaller chunks, Gerd Hoffmann, 2021/01/15
- [PULL 26/30] audio: foo* bar" should be "foo *bar"., Gerd Hoffmann, 2021/01/15
- [PULL 30/30] audio: space prohibited between function name and parenthesis'(', Gerd Hoffmann, 2021/01/15
- [PULL 16/30] paaudio: remove unneeded code,
Gerd Hoffmann <=
- Re: [PULL 00/30] Audio 20210115 patches, no-reply, 2021/01/15
- Re: [PULL 00/30] Audio 20210115 patches, Peter Maydell, 2021/01/16