[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/1] target-riscv: support QMP dump-guest-memory
From: |
Andrew Jones |
Subject: |
Re: [PATCH v3 1/1] target-riscv: support QMP dump-guest-memory |
Date: |
Fri, 15 Jan 2021 09:45:30 -0500 |
On Fri, Jan 15, 2021 at 09:28:19AM +0800, Yifei Jiang wrote:
> Add the support needed for creating prstatus elf notes. Now elf notes
> only contains user_regs. This allows us to use QMP dump-guest-memory.
>
> Signed-off-by: Yifei Jiang <jiangyifei@huawei.com>
> Signed-off-by: Mingwang Li <limingwang@huawei.com>
> ---
> target/riscv/arch_dump.c | 202 +++++++++++++++++++++++++++++++++++++++
> target/riscv/cpu.c | 2 +
> target/riscv/cpu.h | 4 +
> target/riscv/cpu_bits.h | 1 +
> target/riscv/meson.build | 1 +
> 5 files changed, 210 insertions(+)
> create mode 100644 target/riscv/arch_dump.c
>
I gave my r-b on the last review and the only change in this version
is the suggestion I made. Anyway, here's my r-b again
Reviewed-by: Andrew Jones <drjones@redhat.com>
Thanks,
drew