[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] tests/qtest: Remove TPM tests
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 1/4] tests/qtest: Remove TPM tests |
Date: |
Fri, 15 Jan 2021 16:52:24 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
Subject is incorrect, this is not a removal of the tests, but
removal of their execution. The tests are still in the repository.
This is more of a disablement.
On 1/15/21 4:09 PM, Philippe Mathieu-Daudé wrote:
> The TPM tests are failing, and no further tests are run,
> making the rest of the testsuite pointless:
>
> $ make check-qtest
> =================================================================
> ==3330026==ERROR: LeakSanitizer: detected memory leaks
...
> SUMMARY: AddressSanitizer: 449172 byte(s) leaked in 324 allocation(s).
> make: *** [Makefile.mtest:1025: run-test-126] Error 1
>
> Remove these tests to be able to run the rest.
>
> Cc: Stefan Berger <stefanb@linux.ibm.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> tests/qtest/meson.build | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index 16d04625b8b..bcbb04d2bb4 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -41,10 +41,6 @@
> (config_all_devices.has_key('CONFIG_USB_UHCI') and
> \
> config_all_devices.has_key('CONFIG_USB_EHCI') ? ['usb-hcd-ehci-test'] :
> []) + \
> (config_all_devices.has_key('CONFIG_USB_XHCI_NEC') ? ['usb-hcd-xhci-test']
> : []) + \
> - (config_all_devices.has_key('CONFIG_TPM_CRB') ? ['tpm-crb-test'] : []) +
> \
> - (config_all_devices.has_key('CONFIG_TPM_CRB') ? ['tpm-crb-swtpm-test'] :
> []) + \
> - (config_all_devices.has_key('CONFIG_TPM_TIS_ISA') ? ['tpm-tis-test'] : [])
> + \
> - (config_all_devices.has_key('CONFIG_TPM_TIS_ISA') ? ['tpm-tis-swtpm-test']
> : []) + \
> (config_all_devices.has_key('CONFIG_RTL8139_PCI') ? ['rtl8139-test'] : [])
> + \
> qtests_pci +
> \
> ['fdc-test',
>
- [PATCH 0/4] tests/qtest: Fixes fuzz-tests, Philippe Mathieu-Daudé, 2021/01/15
- [PATCH 2/4] tests/qtest: Make fuzz-test generic to all targets, Philippe Mathieu-Daudé, 2021/01/15
- [PATCH 1/4] tests/qtest: Remove TPM tests, Philippe Mathieu-Daudé, 2021/01/15
- Re: [PATCH 1/4] tests/qtest: Remove TPM tests,
Philippe Mathieu-Daudé <=
- Re: [PATCH 1/4] tests/qtest: Remove TPM tests, Stefan Berger, 2021/01/15
- Re: [PATCH 1/4] tests/qtest: Remove TPM tests, Philippe Mathieu-Daudé, 2021/01/15
- Re: [PATCH 1/4] tests/qtest: Remove TPM tests, Philippe Mathieu-Daudé, 2021/01/15
- Re: [PATCH 1/4] tests/qtest: Remove TPM tests, Stefan Berger, 2021/01/15
- Re: [PATCH 1/4] tests/qtest: Remove TPM tests, Stefan Berger, 2021/01/15
- Re: [PATCH 1/4] tests/qtest: Remove TPM tests, Philippe Mathieu-Daudé, 2021/01/16
Re: [PATCH 1/4] tests/qtest: Remove TPM tests, Paolo Bonzini, 2021/01/17
[PATCH 3/4] tests/qtest: Only run fuzz-megasas-test if megasas device is available, Philippe Mathieu-Daudé, 2021/01/15