[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC Qemu PATCH v2 1/2] spapr: drc: Add support for async hcalls at
From: |
Shivaprasad G Bhat |
Subject: |
Re: [RFC Qemu PATCH v2 1/2] spapr: drc: Add support for async hcalls at the drc level |
Date: |
Tue, 19 Jan 2021 12:40:31 +0530 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
Thanks for the comments!
On 12/28/20 2:08 PM, David Gibson wrote:
On Mon, Dec 21, 2020 at 01:08:53PM +0100, Greg Kurz wrote:
...
The overall idea looks good but I think you should consider using
a thread pool to implement it. See below.
I am not convinced, however. Specifically, attaching this to the DRC
doesn't make sense to me. We're adding exactly one DRC related async
hcall, and I can't really see much call for another one. We could
have other async hcalls - indeed we already have one for HPT resizing
- but attaching this to DRCs doesn't help for those.
The semantics of the hcall made me think, if this is going to be
re-usable for future if implemented at DRC level. Other option
is to move the async-hcall-state/list into the NVDIMMState structure
in include/hw/mem/nvdimm.h and handle it with machine->nvdimms_state
at a global level.
Hope you are okay with using the pool based approach that Greg
suggested.
Please let me know.
Thanks,
Shivaprasad
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [RFC Qemu PATCH v2 1/2] spapr: drc: Add support for async hcalls at the drc level,
Shivaprasad G Bhat <=