Re: [PATCH v3] Add support for pvpanic pci device

[Peter Maydell]

On Tue, 19 Jan 2021 at 13:29, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Fri, 15 Jan 2021 at 19:21, Mihai Carabas <mihai.carabas@oracle.com> wrote:
> >
> > This patchset adds support for pvpanic pci device.
> >
> > v3 applied feedback:
> >
> > - patch 1: made pvpanic isa device available only for PC, compile 
> > pvpanic-test
> >   only when isa device is present
> >
> > - patch 2: fixed device id to 0x0011, used OBJECT_DECLARE_TYPE,
> >   PVPANIC_PCI_DEVICE, added VMSTATE_PCI_DEVICE, removed 
> > INTERFACE_PCIE_DEVICE
> >
> > - patch 3: fixed documentation
> >
> > - patch 4: add a qtest for pvpanic-pci
> >
> > Mihai Carabas (4):
> >   hw/misc/pvpanic: split-out generic and bus dependent code
> >   hw/misc/pvpanic: add PCI interface support
> >   pvpanic : update pvpanic spec document
> >   tests/qtest: add a test case for pvpanic-pci
>
> Since the only issue in this version was a minor thinko in
> the docs, I'm going to apply this to target-arm.next and
> make that s/device/bus/ docs fix there. (target-arm seems like
> a reasonable queue to use since the main reason for having
> this device is for the virt board.)

It turns out that the new pvpanic-pci-test fails for i386 targets:

Running test qtest-i386/pvpanic-pci-test
**
ERROR:../../tests/qtest/pvpanic-pci-test.c:46:test_panic: assertion
failed (qdict_get_str(data, "action") == "pause"): ("poweroff" ==
"pause")
ERROR qtest-i386/pvpanic-pci-test - Bail out!
ERROR:../../tests/qtest/pvpanic-pci-test.c:46:test_panic: assertion
failed (qdict_get_str(data, "action") == "pause"): ("poweroff" ==
"pause")

So I'm dropping it from my target-arm.next queue; could you investigate
the issue, please?

thanks
-- PMM